-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(simple-editor): show additional actions inline #5906
base: main
Are you sure you want to change the base?
Conversation
szaimen
commented
Apr 8, 2024
•
edited
Loading
edited
Before | After |
---|---|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5906 +/- ##
=========================================
Coverage 23.31% 23.31%
Complexity 442 442
=========================================
Files 247 247
Lines 11444 11444
Branches 1923 1923
=========================================
Hits 2668 2668
Misses 8776 8776
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
daf2b37
to
fc5e549
Compare
Signed-off-by: Simon L <[email protected]>
fc5e549
to
357300d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some actions are more important or relevant than others here. Showing all of them inline is a bit much and results in a lot of icons without text, which we want to avoid because it is not readily understandable for people who do not use the software every day. :)
- Download and Copy is not as important as "Delete" and "Edit"
- The actions belong more to "Edit" than they do to the close button at the top