2-2 로그인 리팩토링 #50
Open
2-2 로그인 리팩토링 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewWisdom
requested changes
Jul 23, 2024
Comment on lines
+54
to
+56
| if(user.getRole() != Role.ADMIN){ | ||
| throw new AuthorizationException(ErrorCode.UNAUTHORIZED_ADMIN, "관리자 권한이 필요합니다."); | ||
| } |
There was a problem hiding this comment.
이번 단계에서 어느정도 admin 기능에 대한 권한 제어를 해주셨네요 👍
다음 단계 요구사항으로 interceptor 를 통해 검증하도록 바꾸면서 interceptor 의 역할에 대해 더 깊게 체감할 수 있겠군요!
Comment on lines
+49
to
+53
| // if(user.getRole() == Role.ADMIN) { | ||
| // User user = authRepository.findById(request.getUserId()) | ||
| // .orElseThrow(() -> new UserNotFoundException(ErrorCode.USER_NOT_FOUND, "해당 회원이 존재하지 않습니다.")); | ||
| // } | ||
|
|
| @@ -2,11 +2,14 @@ | |||
|
|
|||
| import roomescape.domain.User; | |||
|
|
|||
| import java.util.List; | |||
| import java.util.Optional; | |||
|
|
|||
| public interface AuthRepository { | |||
There was a problem hiding this comment.
해당 repository의 네이밍에 Auth 가 들어가기 보다 데이터 네임에 맞게 UserRepository 와 같이 되는 것은 어떤가요~?
repository 의 역할은 해당 데이터의 접근이 auth와 관련된다는 것은 모르고 단순히 user 데이터에 액세스하는 역할로 볼 수 있을 것 같아서요!
There was a problem hiding this comment.
추가로 회원과 관련된 테이블을 user 로 네이밍했는데, 보통 user는 데이터베이스의 예약어로 사용될 수 있어 사용을 권장하지 않는 것 같아요.
h2 에서도 user 를 예약어로 사용하고 있네요 :)
member 와 같은 다른 네이밍을 적용해보는 것은 어떨까요~?
| import java.util.Optional; | ||
|
|
||
|
|
||
| public class LoginArgumentResolver implements HandlerMethodArgumentResolver { |
| import roomescape.dto.auth.AuthCheckResponse; | ||
| import roomescape.dto.auth.AuthLoginRequest; | ||
| import roomescape.dto.auth.AuthUserResponse; | ||
| import roomescape.dto.auth.UserResponse; | ||
| import roomescape.exception.ErrorCode; | ||
| import roomescape.exception.custom.AuthorizationException; | ||
| import roomescape.exception.custom.CookieNotFoundException; | ||
| import roomescape.service.AuthService; | ||
| import roomescape.util.CookieUtil; | ||
|
|
||
| import java.util.Arrays; |
There was a problem hiding this comment.
현재 signUp 페이지가 정상 작동 하지 않는데 확인 부탁드려요!
| @@ -1,20 +1,22 @@ | |||
| package roomescape.dto.reservation.create; | |||
|
|
|||
| import jakarta.validation.constraints.*; | |||
| import roomescape.domain.User; | |||
|
|
|||
| public class ReservationCreateRequest { | |||
There was a problem hiding this comment.
미션 요구사항에 맞게 API 스펙이 변경되지 않은 것 같은데 확인 부탁드려요!
POST /reservations HTTP/1.1
authorization: Bearer eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiIxIiwiaWF0IjoxNjYzMjk4NTkwLCJleHAiOjE2NjMzMDIxOTAsInJvbGUiOiJBRE1JTiJ9.-OO1QxEpcKhmC34HpmuBhlnwhKdZ39U8q91QkTdH9i0
content-type: application/json; charset=UTF-8
host: localhost:8080
{
"scheduleId": 1
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님.
많이 늦었습니다...😢
최대한 깔끔하게 짜보고 싶었는데 쉽지 않네요...
일단 다 만들긴 한 거 같은데 맞게 만들었는지는 잘모르겠습니다..