-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STEP-2] 로또(자동) #1054
Open
0703kyj
wants to merge
15
commits into
next-step:0703kyj
Choose a base branch
from
0703kyj:step2
base: 0703kyj
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+493
−3
Open
[STEP-2] 로또(자동) #1054
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0eeefef
[STEP-2] init
0703kyj b565de4
[STEP-2] 기능목록 작성
0703kyj 8985d39
[STEP-2] 구매금액 관련 테스트
0703kyj 31af8e4
[STEP-2] 구매금액 구현
0703kyj 2a910cb
[STEP-2] 유저테스트 목록 작성
0703kyj 9180d34
[STEP-2] 유저는 구매금액을 알고 있다.
0703kyj c767b0f
[STEP-2] 로또 추가
0703kyj 4743ea7
[STEP-2] 로또 추가
0703kyj 5e85811
[STEP-2] 당첨번호 추가
0703kyj 672ed89
[STEP-2] 당첨 번호에 따른 맞춘 개수를 로또가 가지고 있는다
0703kyj 5c49d4a
[STEP-2] 일치한 개수 별로 당첨 금액이 다르게 책정된다
0703kyj 48cfead
[STEP-2] 로또 정보 출력 로직 추가
0703kyj 3c7a55a
[STEP-2] 수익률 출력 기능 추가
0703kyj e587585
[STEP-2] 당첨금액 계산 테스트 추가
0703kyj 8c8bc13
[STEP-2] 테스트 수정
0703kyj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[STEP-2] 로또 추가
commit 4743ea7f4c9b6e9a5a14772083b0a752fb55a05a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
package lotto | ||
|
||
import lotto.domain.LottoPurchaseAmount | ||
import lotto.domain.User | ||
import lotto.domain.LottoUser | ||
import lotto.view.InputView | ||
|
||
fun main() { | ||
val lottoPurchaseAmount = LottoPurchaseAmount(InputView.inputPurchaseAmount()) | ||
val user = User(lottoPurchaseAmount) | ||
val lottoUser = LottoUser(lottoPurchaseAmount) | ||
} |
2 changes: 1 addition & 1 deletion
2
lotto/src/main/kotlin/lotto/domain/User.kt → ...src/main/kotlin/lotto/domain/LottoUser.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기능 목록을 잘 만들어주셨네요 👍
이렇게 작성하신 기능 목록이 결국에는 커밋 단위, 테스트 시나리오까지 이어지게 되는데요,
특히 TDD를 하시는 과정에서 객체 설계 및 “어떤 시나리오를 테스트해야 하지“에 대한 본인만의 답을 만들기에도 도움이 될거예요.