3단계 구현 #3973
Open
3단계 구현 #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csh0034
requested changes
Nov 8, 2024
| @@ -34,8 +34,8 @@ public List<Integer> checkMatchingNumber(List<LottoNumber> inputWinningNumbers) | |||
| return totalLottoTicket.getMatchingCounts(new Lotto(inputWinningNumbers)); | |||
| } | |||
|
|
|||
| public Map<PrizePolicy, Integer> winningResult(List<Integer> matchingLottoTickets) { | |||
| return totalLottoTicket.calculateWinLottoTicket(matchingLottoTickets); | |||
| public Map<PrizePolicy, Integer> winningResult(List<Integer> matchingLottoTickets, LottoNumber bonusBall) { | |||
There was a problem hiding this comment.
이전에 드린 코멘트와 같이 컨트롤러는 도메인을 상태로 관리하지 않아야합니다.
현재 LottoDisplay 가 컨트롤러의 역할처럼 보이네요!
현재 Lottos 를 통해 로직이 모두 처리되므로 옮겨보시는것도 좋을것 같아요.
추가로 checkMatchingNumber 의 반환값이 winningResult 로 반드시 전달 된다면
메서드를 분리하지 않는것이 명확하지 않을까요?
| @@ -25,10 +25,13 @@ public List<Integer> getMatchingCounts(Lotto winningLotto) { | |||
| .collect(Collectors.toList()); | |||
| } | |||
|
|
|||
| public Map<PrizePolicy, Integer> calculateWinLottoTicket(List<Integer> matchingLottoTickets) { | |||
| public Map<PrizePolicy, Integer> calculateWinLottoTicket(List<Integer> matchingLottoTickets, LottoNumber bonusBall) { | |||
There was a problem hiding this comment.
List<Integer> matchingLottoTickets, LottoNumber bonusBall
뒤의 인자는 입력한 보너스볼인데 앞의 인자는 입력한 로또 숫자가아니네요!
위의 드린 코멘트 참고하셔서 고민해보시면 좋을것 같습니다.
| @@ -3,9 +3,13 @@ | |||
| import java.util.Arrays; | |||
|
|
|||
| public enum PrizePolicy { | |||
| ZERO(0, 0), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
너무 늦었네요.. 리뷰 부탁드립니다.. ㅠ