[로또 미션] 김성재 미션 제출합니다. #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dradnats1012
reviewed
Jul 9, 2024
| import domain.LottoMachine; | ||
| import domain.WinningNumbers; | ||
|
|
||
| public class Application { |
There was a problem hiding this comment.
개인적으로 실행시키는 클래스는 깔끔해야 한다고 생각해서 동작들을 클래스로 빼면 좋을 것 같아요!
src/main/java/InputHandler.java
Outdated
Comment on lines
18
to
19
| int manualCount = scanner.nextInt(); | ||
| scanner.nextLine(); |
There was a problem hiding this comment.
int manualCount = Integer.parseInt(scanner.nextLine);
으로 한번에 하는건 어떤가요?
src/main/java/InputHandler.java
Outdated
| System.out.println("수동으로 구매할 번호를 입력해 주세요."); | ||
| for (int i = 0; i < manualCount; i++) { | ||
| String input = scanner.nextLine(); | ||
| String[] inputs = input.split(", "); |
Comment on lines
+18
to
+20
| if (this.numbers.size() != 6) { | ||
| throw new IllegalArgumentException("로또 번호는 중복되지 않아야 합니다."); | ||
| } |
src/main/java/InputHandler.java
Outdated
There was a problem hiding this comment.
InputHandler 클래스인만큼 입력값만 받아주고 처리는 해당 입력을 사용하는 클래스에서 하는게 좋다고 생각하는데 어떻게 생각하시나요?
Comment on lines
31
to
49
| private WinningRank determineRank(Lotto lotto) { | ||
| int match = winningNumbers.countMatchingNumbers(lotto); | ||
| if (match == 6) { | ||
| return WinningRank.SIX; | ||
| } | ||
| if (match == 5 && winningNumbers.containsBonusNumber(lotto)) { | ||
| return WinningRank.FIVE_WITH_BONUS; | ||
| } | ||
| if (match == 5) { | ||
| return WinningRank.FIVE; | ||
| } | ||
| if (match == 4) { | ||
| return WinningRank.FOUR; | ||
| } | ||
| if (match == 3) { | ||
| return WinningRank.THREE; | ||
| } | ||
| return WinningRank.NONE; | ||
| } |
There was a problem hiding this comment.
WinningRank 클래스에 bonusNumber 여부도 추가해서 관리하는것도 괜찮을 것 같아요
Comment on lines
52
to
60
| System.out.println("당첨 통계"); | ||
| System.out.println("---------"); | ||
| System.out.println("3개 일치 (5000원) - " + matchCount.get(WinningRank.THREE) + "개"); | ||
| System.out.println("4개 일치 (50000원) - " + matchCount.get(WinningRank.FOUR) + "개"); | ||
| System.out.println("5개 일치 (1500000원) - " + matchCount.get(WinningRank.FIVE) + "개"); | ||
| System.out.println("5개 일치, 보너스 볼 일치 (30000000원) - " + matchCount.get(WinningRank.FIVE_WITH_BONUS) + "개"); | ||
| System.out.println("6개 일치 (2000000000원) - " + matchCount.get(WinningRank.SIX) + "개"); | ||
| double profitRate = calculateProfitRate(matchCount); | ||
| System.out.printf("총 수익률은 %.4f입니다.%n", profitRate); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
여러 날에 걸쳐서 충분히 고민해가보며 했어야 했는데 급하게 몰아서 했네요..ㅠ
상당히 코드가 정돈 되지 못한 것 같은데 어떻게 해야 더 나을지 계속 고민해보겠습니다.