Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
step3 #386
base: hyesooo
Are you sure you want to change the base?
step3 #386
Changes from all commits
821c7bf
53740e3
b83b6ca
cb25131
40b28a5
e6385aa
48a48db
e6c0821
386422c
51a9602
7028a0b
c3a906e
be7549b
766f65b
f1362b6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수강 인원이 1명 이상일 때 의미가 있기 때문에 1이상의 값인지에 대한 검증 로직도 필요하지 않을까?
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
강의료도 1000원 이상과 같이 본인만의 정책을 만들고 유효성 처리하도록 구현하는 것은 어떨까?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
부생성자가 주생성자 앞에 오는 것이 관례임
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
부생성자는 주생성자를 호출해 필드의 값을 초기화하는 것을 추천
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 객체는 Course를 가지는 것 이외에 아무 역할도 담당하고 있지 않다.
이 객체가 필요한 이유는?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 메서드의 로직을 Enrollment와 같은 도메인 객체를 추가해 로직을 분리해 보는 것은 어떨까?
Enrollment는 수강신청 로직 구현을 위해 필요한 capacity와 수강생 목록(participants)을 인스턴스 변수로 가지면 어떨까?