-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π· step3 : μ¦κ²¨μ°ΎκΈ° κΈ°λ₯ ꡬν #241
Open
minyul
wants to merge
10
commits into
next-step:minyul
Choose a base branch
from
minyul:step3
base: minyul
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ba01b3c
refactor : ObjectMapper μμ
minyul bc0773b
refactor : 곡ν΅μΌλ‘ λ€μ΄κ°λ authenticate ν¨μλ₯Ό 리ν©ν λ§νλ€
minyul d6285c7
test : test ν λ§λ€κΈ°
minyul 93395aa
feat & test : μ¦κ²¨μ°ΎκΈ° μμ±
minyul ff5dd75
test & feat : μ¦κ²¨μ°ΎκΈ°λ₯Ό μ‘°ννλ€
minyul d838e0a
test & feat : μ¦κ²¨μ°ΎκΈ°λ₯Ό μμ νλ€
minyul a21678b
refactor : Authorizer λ΄λΆ λ©μλ
minyul 0c52d1a
refactor & test : μ¦κ²¨μ°ΎκΈ° μ‘°ννλ λΆλΆμ μμ νλ€
minyul b20453e
feat & test : λΉλ‘κ·ΈμΈ κ²½μ° μ¦κ²¨μ°ΎκΈ° κΈ°λ₯μ μ¬μ©ν μ μλ€
minyul cc6bcd8
refactor : κ°μ μ°Έμ‘°λ‘ λ°κΎΈλ€
minyul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
νλλͺ μ΄ memberIdλ‘ νλκ² μ ν©νμ§ μμκΉμ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@minyul
μ μ νλ‘μ νΈμμ μ΄λ€ μν©μ΄μλ μ§λ μ κ° μ νν μ μ§ λͺ»νμ¬μ μ νν λ΅λ³λλ¦¬μ§ λͺ»νκ² λ€μ.
νμ§λ§ μλ§ νΌλλ°± μ£Όμ μ¬μλΆμ μλκ° νμ μ¬μ©μκ° κ΄λ ¨λ λΆλΆμ 무쑰건 μ§μ μ°Έμ‘°νκ³ , κ·Έκ² μλλΌλ©΄ κ°μ μ°Έμ‘°ν΄λΌ. μλ°μλ―Έλ μλμμ κ² κ°μμ.
μμλ λ§μλλ Έλ€μνΌ μ§μ μ°Έμ‘°, κ°μ μ°Έμ‘°λ κ°μ μ₯λ¨μ μ΄ μμ΅λλ€. μ κ°μ κ²½μ°λ μ¬μ©μμ κ΄λ ¨λ μν°ν°μμ λ€λ₯Έ μν°ν°μ μ§μ μ°Έμ‘°νλ©΄ λ°λ‘ λ°μ΄ν°λ₯Ό κ°μ Έμμ μ¬μ©ν μ μλ μ₯μ λλΉ λ€λ₯Έ μν°ν°μ κ²°ν©λκ° λμμ§λ λ¬Έμ , N+1μ΄ μκΈΈ μνμ νμ μ κ²½μ¨μΌνλ λ¬Έμ κ° λ ν¬λ€κ³ μκ°ν΄μ κ°μ μ°Έμ‘°νκ±°λ, μλλ°© μν°ν° μͺ½μμ Memberμͺ½μΌλ‘ λ¨λ°©ν₯ μ°κ΄κ΄κ³λ₯Ό λ§Ίλλ‘ νκΈ°λ₯Ό μ νΈνλ νΈμ λλ€ π