ensure fileblob does not create temp files in OS's temp directory (respects 'export-path' config instead) #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spects 'export-path' config instead) google/go-cloud#3294
imyousuf
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Go fileblob creates local files using
os.tempdirwhich tries to create files in/tmpin Linux. If we try to store the final files in a path mounted by an external volume (e.g: PV in K8s), this produces ainvalid cross device linkerror. Details: google/go-cloud#3294Furthermore, the
/tmppath lies under the pod ephemeral storage in K8s and therefore, the disk size is not guaranteed!This PR addresses the issue by applying the suggested solutions by the maintainers of fileblob. The solution is to append a
no_tmp_dirquery parameter tofile://urls. This should allow using K8s persistent volumes to store local archive files during db pruning.