Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Build Windows images #1142

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: Build Windows images #1142

wants to merge 7 commits into from

Conversation

zeitlerc
Copy link
Contributor

@zeitlerc zeitlerc commented Nov 25, 2024

Description

Draft: Currently only builds an image and saves it as an artifact so that the image can be downloaded from Github Actions for testing. The image is not published to Dockerhub

Builds nri-kubernetes into a Windows docker container. The intention is for the Kubelet Scraper component to be deployed onto Windows nodes.

Using docker build and not buildx because of Windows https://docs.docker.com/reference/cli/docker/build-legacy/

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants