Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated default config to accept undefined as default value #2917

Merged

Conversation

svetlanabrennan
Copy link
Contributor

Description

Our current configuration doesn't allow an undefined value for a 3 layers deep/nested config item. This PR allows that now.

How to Test

Run unit tests

Related Issues

Fixes #2871

Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.60%. Comparing base (cc65763) to head (14672bd).
Report is 15 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (cc65763) and HEAD (14672bd). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (cc65763) HEAD (14672bd)
unit-tests-18.x 1 0
unit-tests-22.x 1 0
unit-tests-20.x 1 0
integration-tests-cjs-18.x 1 0
integration-tests-cjs-20.x 1 0
integration-tests-esm-18.x 1 0
versioned-tests-18.x 1 0
integration-tests-esm-20.x 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2917      +/-   ##
==========================================
- Coverage   97.39%   88.60%   -8.80%     
==========================================
  Files         310      312       +2     
  Lines       47512    47635     +123     
==========================================
- Hits        46276    42208    -4068     
- Misses       1236     5427    +4191     
Flag Coverage Δ
integration-tests-cjs-18.x ?
integration-tests-cjs-20.x ?
integration-tests-cjs-22.x 72.70% <100.00%> (-0.37%) ⬇️
integration-tests-esm-18.x ?
integration-tests-esm-20.x ?
integration-tests-esm-22.x 49.67% <100.00%> (-0.17%) ⬇️
unit-tests-18.x ?
unit-tests-20.x ?
unit-tests-22.x ?
versioned-tests-18.x ?
versioned-tests-20.x 79.23% <100.00%> (-0.23%) ⬇️
versioned-tests-22.x 79.24% <100.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svetlanabrennan svetlanabrennan merged commit e049442 into newrelic:main Jan 31, 2025
28 of 29 checks passed
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Cannot default configuration item to undefined
3 participants