Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add quickstart for browser page resources #2619

Open
wants to merge 8 commits into
base: release
Choose a base branch
from

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Jan 22, 2025

Summary

This PR adds a quickstart dashboard and installation instructions for new data collected by the browser agent - browser page resources.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

The PR checks have run and found the following warnings:

Warning Filepath
"permissions" field should not be used dashboards/browser-page-resources/browser-page-resources.json

Reference the Contributing Docs for Dashboards for more information.

@metal-messiah metal-messiah changed the title Add quickstart for browser page resources feat: Add quickstart for browser page resources Jan 22, 2025
Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @metal-messiah, could you please make the review changes.

  1. Is it possible to add alerts to this quickstart? It's considered best practice.
  2. I noticed that the dashboard chart titles are not in sentence case. It's recommended to use sentence case for them, e.g., Average Duration should be `Average duration.

quickstarts/browser-page-resources/config.yml Outdated Show resolved Hide resolved
quickstarts/browser-page-resources/config.yml Outdated Show resolved Hide resolved
data-sources/browser-page-resources/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sjyothi54
sjyothi54 previously approved these changes Jan 30, 2025
Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @metal-messiah, Could you please address the following comments and implement the same changes in this pull request as well?
https://github.com/newrelic/newrelic-quickstarts/pull/2618/files#diff-ea46786b6683ec057ebefa607433a49265ebfe9f04076175a0dc1546042c9fa3

@metal-messiah
Copy link
Member Author

Hi @RamanaReddy8801, @pkudikyala

I have applied the name changes in the dashboard JSON. As far as alerts, we have not established common criteria to alert on for this dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants