Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update network-flow-devices data source #2163

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

mickeyryan42
Copy link
Contributor

https://new-relic.atlassian.net/browse/NR-172764

Updating the data source to point to network-syslog as per the first A/C.

Copy link

Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback!

Copy link
Contributor

@brammerl brammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for Alec to confirm that the PR failure is okay before merging

@aswanson-nr
Copy link
Contributor

Yep, that's just a helper job that updates an unused project board!

Copy link
Contributor

@brammerl brammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood the ticket AC and am approving once again bc we do want to remove the tile itself!

d3caf
d3caf previously approved these changes Dec 12, 2023
brammerl
brammerl previously approved these changes Dec 13, 2023
Copy link

Old PRs will be closed after 30 days of inactivity. This PR has been quiet for 14 days and is being marked as stale. Reply here to keep this PR open.

@aswanson-nr
Copy link
Contributor

Not stale

@mickeyryan42 mickeyryan42 changed the base branch from main to release January 8, 2024 20:01
@mickeyryan42 mickeyryan42 dismissed stale reviews from brammerl and d3caf January 8, 2024 20:01

The base branch was changed.

@mickeyryan42 mickeyryan42 merged commit 8051da2 into release Jan 8, 2024
16 checks passed
@mickeyryan42 mickeyryan42 deleted the mickey/NR-172764-remove-network-flow-devices branch January 8, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants