test: Use a pre-built Amazon Linux image with ASP.NET Core already installed #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tippmar-nr
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2114 +/- ##
==========================================
- Coverage 81.06% 81.04% -0.02%
==========================================
Files 395 395
Lines 24715 24715
Branches 2970 2970
==========================================
- Hits 20035 20031 -4
- Misses 3894 3897 +3
- Partials 786 787 +1 |
nrcventura
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Dockerfile.amazonto use a pre-built Amazon Linux image that has ASP.NET Core already installed, served from the DotNetReg private Azure container registry under our .NET Team Sandbox Azure subscription. This will significantly reduce the execution time for the Amazon container integration tests, specifically the arm64 version of that test.Also includes instructions and a couple of new Dockerfiles to allow rebuilding the custom images.