Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Roll back to previous FirstInteraction implementation #1359

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

metal-messiah
Copy link
Member

Setting agent back to previous FirstInteraction implementation after some reports of slow downs around the performance observer on the first input of a page.

Overview

This is being rolled-back until we can evaluate and implement next steps.

Related Issue(s)

This undos the changes in #1319

Testing

Tests have been reverted.

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 29.76 kB / 10.79 kB (gzip) 29.76 kB / 10.79 kB (gzip) 0% / 0.01% (gzip)
lite async-chunk 51.25 kB / 16.71 kB (gzip) 52.6 kB / 17.08 kB (gzip) 2.63% / 2.2% (gzip)
pro loader 51.45 kB / 17.77 kB (gzip) 51.45 kB / 17.78 kB (gzip) 0% / 0.01% (gzip)
pro async-chunk 98.68 kB / 30.15 kB (gzip) 100.16 kB / 30.56 kB (gzip) 1.5% / 1.33% (gzip)
spa loader 59.07 kB / 20.09 kB (gzip) 59.07 kB / 20.08 kB (gzip) 0% / -0.01% (gzip)
spa async-chunk 113.39 kB / 34.48 kB (gzip) 114.87 kB / 34.88 kB (gzip) 1.31% / 1.16% (gzip)

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.65%. Comparing base (cb866e5) to head (51fc6e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1359      +/-   ##
==========================================
- Coverage   88.70%   88.65%   -0.06%     
==========================================
  Files         170      170              
  Lines        7331     7331              
  Branches     1486     1487       +1     
==========================================
- Hits         6503     6499       -4     
- Misses        717      720       +3     
- Partials      111      112       +1     
Flag Coverage Δ
unit-tests 79.94% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 31, 2025

Static Badge

Last ran on January 31, 2025 12:28:12 CST
Checking merge of (076fb20) into main (cb866e5)

Copy link
Contributor

@ellisong ellisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metal-messiah metal-messiah merged commit c2e22ab into main Jan 31, 2025
14 checks passed
@metal-messiah metal-messiah deleted the bugfix-fid-rollback branch January 31, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants