Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test instructions #144

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Update test instructions #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4198c4a
Update test instructions
hannahramadan Jan 17, 2025
1f4b5c0
Fix all instances of controllerManager.manager.image.tag
TimPansino Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:
helm upgrade --install k8s-agents-operator k8s-agents-operator/k8s-agents-operator \
--namespace=default \
--set=licenseKey=${{ secrets.NEW_RELIC_LICENSE_KEY }} \
--set=controllerManager.manager.image.tag=${{ inputs.K8S_OPERATOR_IMAGE_TAG }}
--set=controllerManager.manager.image.version=${{ inputs.K8S_OPERATOR_IMAGE_TAG }}
sleep 5
kubectl wait --for=condition=Ready -n default --all pods

Expand Down
12 changes: 4 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,23 +71,19 @@ export NEW_RELIC_LICENSE_KEY=***
```bash
make -f tests/Makefile minikube
```
3. Install [cert-manager](https://cert-manager.io/).
```bash
make -f tests/Makefile cert-manager
```
4. Install the New Relic [Kubernetes Agents Operator](https://github.com/newrelic/k8s-agents-operator/)
3. Install the New Relic [Kubernetes Agents Operator](https://github.com/newrelic/k8s-agents-operator/)
```bash
make -f tests/Makefile operator
```
5. Build a local copy of the init container in minikube.
4. Build a local copy of the init container in minikube.
```bash
make -f tests/Makefile build-initcontainer
```
6. Build a local copy of the test app in minikube.
5. Build a local copy of the test app in minikube.
```bash
make -f tests/Makefile build-testapp
```
7. Deploy the test app instrumented with the init container. A browser window will open if the deployment succeeds.
6. Deploy the test app instrumented with the init container. A browser window will open if the deployment succeeds.
```bash
make -f tests/Makefile test
```
Expand Down
4 changes: 2 additions & 2 deletions tests/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ operator:
helm repo add k8s-agents-operator https://newrelic.github.io/k8s-agents-operator
helm upgrade --install k8s-agents-operator k8s-agents-operator/k8s-agents-operator \
--set=licenseKey=${NEW_RELIC_LICENSE_KEY} \
--set=controllerManager.manager.image.tag=edge
--set=controllerManager.manager.image.version=edge
sleep 5
kubectl wait --for=condition=Ready pods $$(kubectl get pods | grep k8s-agents-operator | cut -d" " -f1)

Expand All @@ -45,7 +45,7 @@ operator-local:
--set=newRelicHost=${NEW_RELIC_HOST} \
--set=controllerManager.manager.image.pullPolicy=Never \
--set=controllerManager.manager.image.repository=e2e/k8s-agents-operator \
--set=controllerManager.manager.image.tag=e2e
--set=controllerManager.manager.image.version=e2e
TimPansino marked this conversation as resolved.
Show resolved Hide resolved
sleep 5
kubectl wait --for=condition=Ready pods $$(kubectl get pods | grep k8s-agents-operator | cut -d" " -f1)

Expand Down
Loading