Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: v4 sdk fixes #174

Merged
merged 25 commits into from
Jan 9, 2025
Merged

feat: v4 sdk fixes #174

merged 25 commits into from
Jan 9, 2025

Conversation

dbudziwojskiNR
Copy link
Contributor

@dbudziwojskiNR dbudziwojskiNR commented Jan 7, 2025

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@dbudziwojskiNR dbudziwojskiNR changed the title dbudziwojski/v4 sdk fixes feat: v4 sdk fixes Jan 7, 2025
danielstokes
danielstokes previously approved these changes Jan 8, 2025
Base automatically changed from dbudziwojski/update-scaffolding to main January 8, 2025 22:00
@dbudziwojskiNR dbudziwojskiNR dismissed danielstokes’s stale review January 8, 2025 22:00

The base branch was changed.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.20%. Comparing base (b483638) to head (f2ebe1c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files          21       21           
  Lines        1549     1549           
=======================================
  Hits         1041     1041           
  Misses        425      425           
  Partials       83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbudziwojskiNR dbudziwojskiNR marked this pull request as ready for review January 8, 2025 23:26
@dbudziwojskiNR dbudziwojskiNR requested a review from a team as a code owner January 8, 2025 23:27
@dbudziwojskiNR dbudziwojskiNR merged commit 744428b into main Jan 9, 2025
26 checks passed
@dbudziwojskiNR dbudziwojskiNR deleted the dbudziwojski/v4-sdk-fixes branch January 9, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants