Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(php): add 8.4 support #165

Merged
merged 3 commits into from
Jan 16, 2025
Merged

feat(php): add 8.4 support #165

merged 3 commits into from
Jan 16, 2025

Conversation

ZNeumann
Copy link
Contributor

@ZNeumann ZNeumann commented Nov 25, 2024

Description

The PHP Agent is planned to release support for PHP 8.4 during the week of Jan 13.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.44%. Comparing base (16df151) to head (efbbfc4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   57.44%   57.44%           
=======================================
  Files          36       36           
  Lines        2914     2914           
=======================================
  Hits         1674     1674           
  Misses       1094     1094           
  Partials      146      146           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/apm/php.go Outdated Show resolved Hide resolved
@ZNeumann ZNeumann marked this pull request as ready for review January 6, 2025 19:24
@ZNeumann ZNeumann requested a review from a team as a code owner January 6, 2025 19:24
bduranleau-nr
bduranleau-nr previously approved these changes Jan 6, 2025
mfulb
mfulb previously approved these changes Jan 7, 2025
@danielstokes danielstokes merged commit 245c4dc into main Jan 16, 2025
17 of 18 checks passed
@danielstokes danielstokes deleted the php/8.4 branch January 16, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants