Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: health sidecar #112

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: health sidecar #112

wants to merge 4 commits into from

Conversation

danielstokes
Copy link
Contributor

Description

Adds health APM support.

TODO:

  • Add tests
  • Fix Restart policy 1

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

Footnotes

  1. requires https://github.com/newrelic/k8s-agents-operator/pull/110 before this can work.

@danielstokes danielstokes requested a review from a team as a code owner October 23, 2024 20:39
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 65.70645% with 250 lines in your changes missing coverage. Please review.

Project coverage is 61.94%. Comparing base (94f652a) to head (5ad3006).

Files with missing lines Patch % Lines
src/instrumentation/health.go 69.48% 107 Missing and 23 partials ⚠️
src/api/v1alpha2/zz_generated.deepcopy.go 0.00% 32 Missing ⚠️
src/instrumentation/health_check.go 53.12% 10 Missing and 5 partials ⚠️
src/instrumentation/instrumentation_validator.go 0.00% 15 Missing ⚠️
src/apm/health.go 89.38% 8 Missing and 4 partials ⚠️
src/apm/helper.go 78.94% 9 Missing and 3 partials ⚠️
.../instrumentation/instrumentation_status_updater.go 0.00% 8 Missing ⚠️
src/api/v1alpha2/instrumentation_types.go 0.00% 5 Missing ⚠️
src/apm/dotnet.go 50.00% 2 Missing and 1 partial ⚠️
src/apm/golang.go 50.00% 2 Missing and 1 partial ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   60.31%   61.94%   +1.63%     
==========================================
  Files          22       26       +4     
  Lines        1532     2252     +720     
==========================================
+ Hits          924     1395     +471     
- Misses        538      745     +207     
- Partials       70      112      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/apm/health.go Outdated Show resolved Hide resolved
src/apm/health.go Outdated Show resolved Hide resolved
src/apm/health.go Outdated Show resolved Hide resolved
src/apm/health.go Outdated Show resolved Hide resolved
src/apm/php.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

@danielstokes danielstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating in next commit

src/apm/health.go Show resolved Hide resolved
src/apm/health.go Outdated Show resolved Hide resolved
src/apm/health.go Show resolved Hide resolved
src/apm/health.go Show resolved Hide resolved
src/apm/health.go Outdated Show resolved Hide resolved
src/apm/health.go Outdated Show resolved Hide resolved
src/apm/helper.go Show resolved Hide resolved
src/apm/helper.go Show resolved Hide resolved
src/apm/helper.go Show resolved Hide resolved
src/apm/php.go Outdated Show resolved Hide resolved
Copy link

@mvicknr mvicknr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few notes of things we found along the way while integrating with the sidecar

src/apm/health.go Outdated Show resolved Hide resolved
src/apm/health.go Outdated Show resolved Hide resolved
src/instrumentation/instrumentation_validator.go Outdated Show resolved Hide resolved
src/instrumentation/health_check.go Outdated Show resolved Hide resolved
src/instrumentation/health_check.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants