NR-346357: Sync up nr-ebpf-agent charts in helm-charts from newrelic-… #1537

nravada · 2024-12-05T10:21:14Z

…ebpf-agent

Is this a new chart

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

Chart Version bumped
Variables are documented in the README.md
Title of the PR starts with chart name (e.g. [mychartname])

…ebpf-agent

kpattaswamy

Is it possible to add the remaining changes from eBPF repo as well here to get this chart up to date?

kpattaswamy · 2025-01-16T17:01:05Z

charts/nr-ebpf-agent/values.yaml

@@ -131,3 +131,33 @@ nodeSelector: {}
 tolerations: []
 # -- Sets all pods' affinities. Can be configured also with `global.affinity`
 affinity: {}
+# --  Kubernetes cluster domain


I believe you'll need to create new image & tags (need to use the dockerhub registry now since we are moving away from GCR) as well since the existing artifacts don't have the logic to utilize these configuration changes.

You'll also need to run helm-docs to auto-update the readme with the new changes from this Values.yaml

danielstokes · 2025-01-22T20:23:00Z

charts/nr-ebpf-agent/values.yaml

 proxy: ""
-# -- Drop data when service names map to an IP address.
+# Drop data where to service names mapps to an IP address


mapps misspelling

danielstokes · 2025-01-22T20:28:00Z

charts/nr-ebpf-agent/templates/nr-ebpf-agent-daemonset.yaml

 apiVersion: apps/v1
 kind: DaemonSet
 metadata:
  name: nr-ebpf-agent
  labels:
+    {{- if gt .Chart.Version "0.1.14"}}


For this and all the other occurrences; Why are we checking this? This would make more sense if this "feature" was planned for a later release. Seems to me this conditional is not needed; though I could be wrong.

Removed this check in the latest commit.

nravada · 2025-01-23T08:18:46Z

We have added two labels, app and component, in the spec.selector section of the nr-ebpf-agent-service.yaml file. The Helm upgrade check is failing in the pull request (PR) due to these newly added labels, as Kubernetes does not allow changes to the spec.selector field of an existing Service.

To pass the Helm upgrade check, we temporarily excluded the newly added labels from the spec.selector. This allowed all checks to pass in the PR. After the checks passed, we reverted the temporary changes and included the labels again in the latest commit.

Given that the Helm upgrade check failure is due to the immutable nature of the spec.selector field, we can proceed with the changes by neglecting the Helm upgrade check.

kpattaswamy · 2025-01-23T19:02:55Z

charts/nr-ebpf-agent/Chart.yaml

@@ -13,7 +13,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.1.13
+version: 0.1.14


Will need to bump this again

kpattaswamy · 2025-01-23T19:08:57Z

charts/nr-ebpf-agent/values.yaml

    # -- The pull policy is defaulted to IfNotPresent, which skips pulling an image if it already exists. If pullPolicy is defined without a specific value, it is also set to Always.
    pullPolicy: IfNotPresent
    # -- The tag of the eBPF agent image to be deployed.
-    tag: 0.0.5
+    tag: nr-ebpf-agent_0.0.5


Will need to create new images for the agent & client, the changes you are adding for TLS/Sampling/etc. are not present in these existing image tags so any of the respective configurations from the Helm chart will not be picked up by the containers

kpattaswamy · 2025-01-23T19:10:11Z

charts/nr-ebpf-agent/values.yaml

    # -- The pull policy is defaulted to IfNotPresent, which skips pulling an image if it already exists. If pullPolicy is defined without a specific value, it is set to Always.
    pullPolicy: IfNotPresent
    # -- The tag of the eBPF client image to be deployed.
-    tag: 0.0.7
+    tag: nr-ebpf-client_0.0.7


Ditto here for image update

kpattaswamy · 2025-01-23T19:10:54Z

charts/nr-ebpf-agent/values.yaml


-# -- The periodicity in seconds at which the eBPF agent pushes data to the OTel collector for export to NR.
+# The periodicity in seconds at which the eBPF client pushes data to the OTel collector for export to NR.


should be agent here

kpattaswamy · 2025-01-23T19:11:42Z

charts/nr-ebpf-agent/values.yaml

-# while tcp_stats tracks TCP metrics.
-stirlingSources: "socket_tracer,tcp_stats"
-# -- The protocols to enable for tracing in the socket_tracer.
+# while tcp_stats tracks TCP metrics and jvm_stats tracks JVM metrics.


We need to remove the jvm_stats connector from the comment and environment variable since we are not exporting JVM data.

kpattaswamy · 2025-01-23T19:12:47Z

charts/nr-ebpf-agent/values.yaml

 dropDataIpServiceNames: true
-# -- Drop data from the kube-system namespace.
+# Drop data from to the kube-system namespace


We will need to prefix all of the relevant comments with --. This is because the ReadMe's auto generation relies on that prefix in order to add the description.

The auto generation of the ReadMe is done by running helm-docs.

kpattaswamy · 2025-01-23T19:13:58Z

charts/nr-ebpf-agent/values.yaml

 dropDataIpServiceNames: true
-# -- Drop data from the kube-system namespace.
+# Drop data from to the kube-system namespace


Suggested change

# Drop data from to the kube-system namespace

# -- Drop data from the kube-system namespace.

NR-346357: Sync up nr-ebpf-agent charts in helm-charts from newrelic-…

83d10ab

…ebpf-agent

nravada requested a review from a team as a code owner December 5, 2024 10:21

nravada requested review from kpattaswamy, Philip-R-Beckwith, ramkrishankumarN, satya-nr and mbolla22 December 5, 2024 10:23

nravada added 3 commits December 5, 2024 10:46

NR-346357: fix to the lint and test charts, version updated

4f2e421

NR-346357: fix for the lint and test charts, lookup issue

dd02857

NR-346357: fix for the lint and test charts, lookup fn issue

8ddf5df

nravada requested a review from a team as a code owner December 5, 2024 13:13

nravada added 3 commits December 5, 2024 13:29

NR-346357: fix for the lint and test charts, gotpl issue

6fc7257

Merge branch 'master' into NR-346357

edc07dc

NR-346357: chart version updated

1198957

kpattaswamy reviewed Jan 16, 2025

View reviewed changes

nravada and others added 15 commits January 17, 2025 17:46

NR-346357: added latest changes from eBPF repo to helm repo

8e6d879

NR-346357: fixed the check spelling issue

e3f8bd8

NR-346357: removed the old code that generates env vars for protocols

c45f8db

Merge branch 'master' into NR-346357

5547591

Handled lint chart test error

b7f3c63

handled lint chart issue

4c3e0eb

handled lint chart issue

30ac181

handled lint chart issue

1c54fea

handled lint chart issue

37d333d

handled lint chart issue

7398076

handled test upgrade chart issue

ab367b7

handled test upgrade chart issue

301b7da

NR-346357: handled test upgrade chart issue

c6cdc72

NR-346357: handled test upgrade chart issue

5ff48ea

NR-346357: handled test upgrade chart issue

1f70850

nravada added 4 commits January 21, 2025 17:22

NR-346357: handled test upgrade chart issue

f4b549d

NR-346357: handled test upgrade chart issue

c909d44

NR-346357: handled test upgrade chart issue

eeef0e0

NR-346357: handled test upgrade chart issue

560fb6e

nravada requested a review from danielstokes January 22, 2025 18:35

danielstokes reviewed Jan 22, 2025

View reviewed changes

NR-346357: handled test upgrade chart issue

1c89770

kpattaswamy reviewed Jan 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NR-346357: Sync up nr-ebpf-agent charts in helm-charts from newrelic-… #1537

NR-346357: Sync up nr-ebpf-agent charts in helm-charts from newrelic-… #1537

nravada commented Dec 5, 2024 •

edited

Loading

kpattaswamy left a comment

kpattaswamy Jan 16, 2025

danielstokes Jan 22, 2025

danielstokes Jan 22, 2025

nravada Jan 24, 2025

nravada commented Jan 23, 2025 •

edited

Loading

kpattaswamy Jan 23, 2025

kpattaswamy Jan 23, 2025

kpattaswamy Jan 23, 2025

kpattaswamy Jan 23, 2025

kpattaswamy Jan 23, 2025

kpattaswamy Jan 23, 2025

kpattaswamy Jan 23, 2025


		# -- The periodicity in seconds at which the eBPF agent pushes data to the OTel collector for export to NR.
		# The periodicity in seconds at which the eBPF client pushes data to the OTel collector for export to NR.

	# Drop data from to the kube-system namespace
	# -- Drop data from the kube-system namespace.

NR-346357: Sync up nr-ebpf-agent charts in helm-charts from newrelic-… #1537

Are you sure you want to change the base?

NR-346357: Sync up nr-ebpf-agent charts in helm-charts from newrelic-… #1537

Conversation

nravada commented Dec 5, 2024 • edited Loading

Is this a new chart

What this PR does / why we need it:

Which issue this PR fixes

Special notes for your reviewer:

Checklist

kpattaswamy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nravada commented Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nravada commented Dec 5, 2024 •

edited

Loading

nravada commented Jan 23, 2025 •

edited

Loading