[agent-control] feat: rename env var prefix NR_SA to NR_AC (#1554)

<!--
Thank you for contributing to New Relic's Helm charts. Before you submit
this PR we'd like to
make sure you are aware of our technical requirements:

*
https://github.com/newrelic-experimental/helm-charts/blob/master/CONTRIBUTING.md#technical-requirements

For a quick overview across what we will look at reviewing your PR,
please read
our review guidelines:

*
https://github.com/newrelic-experimental/helm-charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the
review process and
help get your PR merged quicker.

When updates to your PR are requested, please add new commits and do not
squash the
history. This will make it easier to identify new changes. The PR will
be squashed
anyways when it is merged. Thanks.

For fast feedback, please @-mention maintainers that are listed in the
Chart.yaml file.

Please make sure you test your changes before you push them. Once
pushed, a Github Action
will run across your changes and do some initial checks and linting.
These checks run
very quickly. Please check the results. We would like these checks to
pass before we
even continue reviewing your changes.
-->
#### Is this a new chart

#### What this PR does / why we need it:

#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)`
format, will close that issue when PR gets merged)*
  - fixes #

#### Special notes for your reviewer:

#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove
unrelated fields.]
- [x] Chart Version bumped
- [ ] Variables are documented in the README.md
- [x] Title of the PR starts with chart name (e.g. `[mychartname]`)

charts/agent-control/Chart.lock

@@ -4,9 +4,9 @@ dependencies:
   version: 2.13.0
 - name: agent-control-deployment
   repository: ""
-  version: 0.0.31-beta
+  version: 0.0.32-beta
 - name: common-library
   repository: https://helm-charts.newrelic.com
   version: 1.3.0
-digest: sha256:f10febd86dc71a6fefdfa6ef0e6e98e3b4ffb9eb931cf3f4cbd297090d6fdc10
-generated: "2024-12-13T09:57:15.834827Z"
+digest: sha256:f0ea6c84b777100b9371589dea16a02eafdd70623b4a4b62014488f460a5dd99
+generated: "2024-12-17T09:37:56.710271Z"

charts/agent-control/Chart.yaml

@@ -3,15 +3,15 @@ name: agent-control
 description: Bootstraps New Relic' Agent Control
 
 type: application
-version: 0.0.31-beta
+version: 0.0.32-beta
 
 dependencies:
   - name: flux2
     repository: https://fluxcd-community.github.io/helm-charts
     version: 2.13.0
     condition: flux2.enabled
   - name: agent-control-deployment
-    version: 0.0.31-beta
+    version: 0.0.32-beta
     condition: agent-control-deployment.enabled
     # The following dependency is needed as sub-dependency of agent-control-deployment
   - name: common-library

charts/agent-control/charts/agent-control-deployment/Chart.yaml

@@ -4,7 +4,7 @@ description: A Helm chart to install New Relic Agent Control on Kubernetes
 
 type: application
 
-version: 0.0.31-beta
+version: 0.0.32-beta
 
 keywords:
   - newrelic

charts/agent-control/charts/agent-control-deployment/templates/deployment-agentcontrol.yaml

@@ -65,19 +65,19 @@ spec:
 
           env:
           {{- if ((.Values.config).fleet_control).enabled }}
-            - name: NR_SA_FLEET_CONTROL__AUTH_CONFIG__CLIENT_ID
+            - name: NR_AC_FLEET_CONTROL__AUTH_CONFIG__CLIENT_ID
               valueFrom:
                 secretKeyRef:
                   name: {{ include "newrelic-agent-control.auth.secret.name" . }}
                   key: {{ include "newrelic-agent-control.auth.secret.clientId.key" . }}
-            - name: NR_SA_FLEET_CONTROL__HEADERS__API-KEY
+            - name: NR_AC_FLEET_CONTROL__HEADERS__API-KEY
               valueFrom:
                 secretKeyRef:
                   name: {{ include "newrelic.common.license.secretName" . }}
                   key: {{ include "newrelic.common.license.secretKeyName" . }}
           {{- end }}
           {{- if include "newrelic.common.verboseLog" . }}
-            - name: NR_SA_LOG__LEVEL
+            - name: NR_AC_LOG__LEVEL
               value: debug
           {{- end }}
 

charts/agent-control/charts/agent-control-deployment/tests/deployment_agentcontrol_env_test.yaml

@@ -52,7 +52,7 @@ tests:
       - contains:
           path: spec.template.spec.containers[0].env
           content:
-            name: NR_SA_FLEET_CONTROL__HEADERS__API-KEY
+            name: NR_AC_FLEET_CONTROL__HEADERS__API-KEY
             valueFrom:
               secretKeyRef:
                 key: licenseKey
@@ -74,7 +74,7 @@ tests:
       - contains:
           path: spec.template.spec.containers[0].env
           content:
-            name: NR_SA_FLEET_CONTROL__HEADERS__API-KEY
+            name: NR_AC_FLEET_CONTROL__HEADERS__API-KEY
             valueFrom:
               secretKeyRef:
                 key: custom-key