Use logger primary filter to hook into error reporting #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaryseed
force-pushed
the
vince/auto-error-backend
branch
from
b8fa10e to
1730c85
Compare
binaryseed
force-pushed
the
vince/auto-error-backend
branch
from
1730c85 to
a2ce11f
Compare
|
Rebased & ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the error reporting situation by leveraging
:loggerfilters to hook into error reports. Support for these goes back to OTP 21, so we're good on all our supported versionsThis also gets us back automatic error instrumentation! I've included a warning to remove the
ErrorLoggerfrom:backendconfiguration for anyone who has done that.This technique is already in use inside the agent for the Logs in Context feature.