Identify Phoenix LiveView metrics #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I submitted an issue to go along with this PR, #425 |
|
Will merge this after #426 |
Is there something I can do to help get this merged? |
|
Up on this one. What can we do to get it merged? |
tpitale
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, all LiveView metrics are named for the plug and action, i.e.
WebTransaction/Phoenix/Phoenix.LiveView.Plug/index.This PR names those metrics after the module and action, i.e.
WebTransaction/Phoenix/PhxExampleWeb.HomeLive/index. This provides more insight into the details of the metric.To properly test,
phoenix_exampleis updated with the latest phoenix packages and the pages and layouts with the modern Phoenix conventions.