Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs: Revise logging metrics explanation #16707

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

rhetoric101
Copy link
Contributor

This is for work on NR-249655. We needed to clarify the differences between logging metrics and APM log forwarding.

@rhetoric101 rhetoric101 added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Mar 28, 2024
@rhetoric101 rhetoric101 self-assigned this Mar 28, 2024
Copy link

Hi @rhetoric101 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment netlify build on this PR to update the preview.

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 247883c
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6606ee37387d8300083f21d4
😎 Deploy Preview https://deploy-preview-16707--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rhetoric101 rhetoric101 marked this pull request as ready for review March 28, 2024 19:29
@github-actions github-actions bot requested a review from jeff-colucci March 28, 2024 19:30
jeff-colucci
jeff-colucci previously approved these changes Mar 28, 2024
Copy link
Contributor

@jeff-colucci jeff-colucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some small things, but once you look them over you're good to go!

Copy link
Contributor

@jeff-colucci jeff-colucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rhetoric101 rhetoric101 merged commit ba85105 into develop Mar 29, 2024
17 checks passed
@rhetoric101 rhetoric101 deleted the rhs-clarify-log-metrics-wording branch March 29, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants