Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name-your-php-application.mdx #16699

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

neilpdx
Copy link
Contributor

@neilpdx neilpdx commented Mar 28, 2024

Removed the note about multiple app naming being available only in PHP agent versions 2.4 or higher. Since versions below PHP agent 5.0 can no longer connect to New Relic, it's no longer necessary to call this out.

Reference:

https://forum.newrelic.com/s/hubtopic/aAX8W0000008aBMWAY/important-upcoming-changes-to-supported-agent-versions

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

Removed the note about multiple app naming being available only in PHP agent versions 2.4 or higher. Since versions below PHP agent 5.0 can no longer connect to New Relic, it's no longer necessary to call this out.

Reference:

https://forum.newrelic.com/s/hubtopic/aAX8W0000008aBMWAY/important-upcoming-changes-to-supported-agent-versions
@CLAassistant
Copy link

CLAassistant commented Mar 28, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Hi @neilpdx 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment netlify build on this PR to update the preview.

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit c4ec079
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/6604b9aaea34690008d97fd7
😎 Deploy Preview https://deploy-preview-16699--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akristen
Copy link
Contributor

Hi @neilpdx . We've updated our CLA again, so will need you to re-sign our CLA.

@akristen akristen self-assigned this Mar 28, 2024
@akristen akristen added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Mar 28, 2024
Copy link
Contributor

@akristen akristen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as CLA is signed, this is good to merge.

@akristen
Copy link
Contributor

akristen commented Apr 4, 2024

Hi @neilpdx . Can you sign the CLA so we can merge this in? thanks!

@akristen akristen merged commit 613efcc into newrelic:develop Apr 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants