Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Integrations): Created a new page for the Atlassian integration #16632

Merged
merged 10 commits into from
Apr 26, 2024

Conversation

nbaenam
Copy link
Contributor

@nbaenam nbaenam commented Mar 22, 2024

PR to create a new page explaining how to integrate New Relic with Atlassian Jira.

This is the ticket: NR-236395

@nbaenam nbaenam added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Mar 22, 2024
@nbaenam nbaenam self-assigned this Mar 22, 2024
Copy link

Hi @nbaenam 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment netlify build on this PR to update the preview.

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit c8d072f
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/662a0952e984400008a73e2c
😎 Deploy Preview https://deploy-preview-16632--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nbaenam nbaenam marked this pull request as ready for review April 12, 2024 14:08
@github-actions github-actions bot requested a review from jeff-colucci April 12, 2024 14:08
@nbaenam nbaenam requested a review from bradleycamacho April 18, 2024 09:40
@nbaenam
Copy link
Contributor Author

nbaenam commented Apr 23, 2024

Although it seems that some checks failed, this PR was built correctly: https://app.netlify.com/sites/docs-website-netlify/deploys/6627913e39670d0598ba13e7

It's important to understand this distinction when setting up an integration. For example, you may want to make sure about generating an API key from a user who has the correct permissions. You may want the user to only have access to certain accounts in the application. This limits what they can see and share with others. For example, say you have more users in your Atlassian application than in your New Relic accounts, and you configure the Atlassian integration. The users in the Atlassian integration will be able to see the New Relic data shared with Atlassian in the Atlassian application. Regardless of whether those users have access to the corresponding New Relic accounts.


## Integration user leverage [#leverag-integration-user]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title is likely accurate but it's a little confusing at first glance, anyway to clarify it?


## Enable the incidents tab [#enable-incidents-tab]

You may need to link to the Atlassian documentation. It walks a Jira site admin through enabling the Incidents tab and assigning it to a workspace. There is a chance they are going to enable by default and then, you won't need this section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that Incidents and incident tab and the like have some inconsistent capitalization that will need to be addressed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is > There's

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a chance they are going to enable by default" reads very awkwardly to me

jeff-colucci
jeff-colucci previously approved these changes Apr 23, 2024
Copy link
Contributor

@jeff-colucci jeff-colucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some comments but once those are addressed I think you're good to publish

@nbaenam
Copy link
Contributor Author

nbaenam commented Apr 26, 2024

I'm going to merge because this has been already reviewed by Jeff and 2 SMEs.

@nbaenam nbaenam merged commit 6db358c into develop Apr 26, 2024
17 checks passed
@nbaenam nbaenam deleted the nb-atlassian-NR-236395 branch April 26, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants