Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scott/training page skeleton #3179

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Scott/training page skeleton #3179

merged 3 commits into from
Jan 21, 2025

Conversation

scwambach
Copy link
Collaborator

@scwambach scwambach commented Jan 16, 2025 •
edited by mflymfly
Loading

resolves NJWE-2552

What I did:

  • added a skeleton shell for the loading state on training detail pages
  • Dev Review
  • Design Review

@scwambach scwambach changed the base branch from main to credential-engine January 16, 2025 16:09
@ChelseaKR
Copy link
Collaborator

looks amazing to me so far

@scwambach scwambach marked this pull request as ready for review January 21, 2025 14:08
mflymfly
mflymfly requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@mflymfly mflymfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Just one issue I am seeing.
If you scroll down the results page and click one, the new page stays scrolled while skeleton loader is active. New page should reset scroll position. (See attached screen recording)

Te-Details-Skeleton-Bug.webm

@scwambach scwambach requested a review from mflymfly January 21, 2025 16:37
mflymfly
mflymfly approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@mflymfly mflymfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ChelseaKR ChelseaKR merged commit fa4554e into credential-engine Jan 21, 2025
2 checks passed
@ChelseaKR ChelseaKR deleted the scott/training-page-skeleton branch January 21, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflymfly mflymfly mflymfly approved these changes

@ChelseaKR ChelseaKR Awaiting requested review from ChelseaKR

@denish-fearless denish-fearless Awaiting requested review from denish-fearless

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scwambach @ChelseaKR @mflymfly