-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Njwe 2406/scott training results page #3169
base: nextjs
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting the following error and unable to see the changes:
Error: fetch failed
at async getSearchData (rsc://React/Server/webpack-internal:///(rsc)/./src/app/training/search/utils/getSearchData.ts?0:13:24)
at async SearchPage (rsc://React/Server/webpack-internal:///(rsc)/./src/app/training/search/page.tsx?1:37:25)
at resolveErrorDev (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js:1792:63)
at processFullStringRow (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js:2071:17)
at processFullBinaryRow (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js:2059:7)
at progress (webpack-internal:///(app-pages-browser)/./node_modules/next/dist/compiled/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js:2262:17)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All below changes captured in prototype link below
- Is it possible for the drawer and cards to animate in / out? I can give some more instruction on that if it is possible.
- Filters button: looks like disabled state in gray. Make it primary outline button.
- Change filter button text "Hide Filters" when drawer is open. "Show filters" when drawer is closed.
- Make green filter drawer Viewport Height on Desktop and allow the user to scroll within that window to see the lower filters
- Filter drawer sticks to top of screen on scroll
- 768>1040 - can we narrow the filer bar just a bit. I think it can just be 20rem just to give the cards a little more room to breathe. They get pretty narrow before breaking to mobile
- Update gaps and max-width of filter drawer per screenshot
resolves NJWE-2406
What I did: