Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC 131 -- Headings on income review page #25

Closed
damiansian opened this issue Jan 5, 2025 · 2 comments
Closed

SC 131 -- Headings on income review page #25

damiansian opened this issue Jan 5, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@damiansian
Copy link

damiansian commented Jan 5, 2025

URL

https://demo.fileyourstatetaxes.org/en/questions/income-review

Issue

There is text on the page that looks like a heading and is grouping content, but is not marked up as a heading.

Screen recording:

headings_color.mp4

Note

This video covers the color issue on the same page. There are two issues created for this.

WCAG

SC 1.3.1: Info and Relationships (Level A)

User impact

Headings are used by screen reader users for navigation and to create a mental model of the page. They group content into a semantic structure. When heading semantics are used on paragraphs, it is disorienting.

Suggested fix

Review the CodePen for suggested edits:
https://codepen.io/dsian108/pen/LEPOXWW?authentication_hash=yoMZEDDNxPxk

@aloverso
Copy link

@damiansian this is fixed and ready for your review here! https://statefile.pr-5387.getyourrefund-testing.org/en

@damiansian
Copy link
Author

Tested on:
https://statefile.pr-5387.getyourrefund-testing.org/en/questions/income-review

The following headings are available.

H1 through H2 used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants