Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NJ 207 - add headers to income page for accessibility #5387

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

aloverso
Copy link
Contributor

@aloverso aloverso commented Jan 17, 2025

Link to pivotal/JIRA issue

https://github.com/newjersey/affordability-pm/issues/207
newjersey/accessibility-pm#25

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

Change headers on income review page to use h2 instead p (styling stays visually the same) to meet WCAG Level A standards to convey info to non sighted users.

How to test?

  • View income review screen
  • Inspect markup
  • Use screenreader to reflect page header breakdown

Copy link

Heroku app: https://gyr-review-app-5387-f2fbbbe64db3.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5387 (optionally add --tail)

Copy link
Contributor

@embarnard embarnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aloverso aloverso merged commit c8350ed into main Jan 17, 2025
7 checks passed
@aloverso aloverso deleted the nj-207-income-review-a11y branch January 17, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants