Unset action and use add_query_arg() to properly add query args.

newfold-labs · Jul 15, 2022 · d2faf8f · d2faf8f
1 parent a67c88f
commit d2faf8f
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/includes/SSO_Helpers.php b/includes/SSO_Helpers.php
@@ -192,6 +192,7 @@ public static function getSuccessUrl() {
 		if ( $url ) {
 			$params = $_GET;
 
+			unset( $params['action'] );
 			unset( $params['bounce'] );
 			unset( $params['nonce'] );
 			unset( $params['redirect'] );
@@ -200,7 +201,12 @@ public static function getSuccessUrl() {
 			unset( $params['user'] );
 
 			// Persist all query params not used for SSO
-			$url .= $params ? '?' . http_build_query( $params ) : '';
+			if ( ! empty( $params ) ) {
+				foreach ( $params as $key => $value ) {
+					$url = add_query_arg( $key, $value, $url );
+				}
+			}
+
 		}
 
 		if ( ! $url ) {