script dismiss-notices.js loasing check

[geckod22]

Proposed changes

Maybe we could add a check to avoid to load the js file dismiss-notices.js if there are no notifications in the collection.

so in the function maybeRenderAdminNotices

we could call this function self::adminScripts();
like this self::adminScripts( $collection->count() );

and then in adminScripts function we could check for the count value before to load the dismiss-notices.js.

Type of Change

Production

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update
• Refactoring / housekeeping (changes to files not directly related to functionality)

Development

• Tests
• Dependency update
• Environment update / refactoring
• Documentation Update

Video

Checklist

• I have read the CONTRIBUTING doc
• I have viewed my change in a web-browser
• Linting and tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments