Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.2.3 #69

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Release/2.2.3 #69

merged 7 commits into from
Dec 16, 2024

Conversation

kreamweb
Copy link

Proposed changes

Fix related to:
https://jira.newfold.com/browse/PRESS6-73

  • Clicking on buttons with the data-nfdhelpcenterquery attribute caused an error to appear below the HC input field. This fix resolves that error.

  • Another fix included in this commit addresses the following issue:
    If the user entered and submitted another query while the results for the previous query were still loading, the new query would display the results of the previous one instead.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@kreamweb kreamweb requested a review from ajayadav09 December 12, 2024 12:53
Copy link
Contributor

@ajayadav09 ajayadav09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging changes to test with new release of ecommerce module.

@ajayadav09 ajayadav09 merged commit 903de7f into main Dec 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants