Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alterations of the Gourd and Bazaar into new mapping standards #871

Merged
merged 6 commits into from
Jan 18, 2024

Conversation

YumiGumi
Copy link
Contributor

About the PR

Updated the Gourd and the Bazaar to align with new mapping standards and guidelines

Why / Balance

Balance and alignment of preexisting ships to newer and more regulated standards

Technical details

N/A

##Media
Bazaar1
gourd

  • [ X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

🆑

  • tweak: Altered the SLI ships to bring them into line with mapping standards

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Jan 12, 2024
@YumiGumi
Copy link
Contributor Author

sorry about the long wait for alot of these rolling changes. but wanted to be sure what 100% needed changed before committing half of my free time to endlessly fixing the same 4 things over and over, if any concerns or alterations need to be made atop this, they shall be tackled tomorrow when i awake

@TsjipTsjip
Copy link
Contributor

TsjipTsjip commented Jan 13, 2024

Please modify .github/mapchecker/whitelist.yml to not list Gourd and Bazaar under the technical debt section, so the mapchecker will start checking against these prototypes which were previously present on these ships.

@YumiGumi
Copy link
Contributor Author

Please modify .github/mapchecker/whitelist.yml to not list Gourd and Bazaar under the technical debt section, so the mapchecker will start checking against these prototypes which were previously present on these ships.

i dunno what this is, so i'm gonna assume you aren't asking me to do something.

@TsjipTsjip
Copy link
Contributor

i dunno what this is, so i'm gonna assume you aren't asking me to do something.

I am. I need you to go on your branch, sync it with master via the big green button on the Github UI, and remove lines 35, 36, 47 and 48 from .github/mapchecker/whitelist.yml.

@YumiGumi
Copy link
Contributor Author

i dunno what this is, so i'm gonna assume you aren't asking me to do something.

I am. I need you to go on your branch, sync it with master via the big green button on the Github UI, and remove lines 35, 36, 47 and 48 from .github/mapchecker/whitelist.yml.

alrighty, then would i push that updated file to this branch?

@TsjipTsjip
Copy link
Contributor

Yup!

@YumiGumi
Copy link
Contributor Author

Yup!

gotcha, my branch was already synched, so i'll just alter that file and push, please hold, should be handled in about a min.

@TsjipTsjip
Copy link
Contributor

Mapchecker is happy! Thanks for doing the technical bit for me, I appreciate that.

@YumiGumi
Copy link
Contributor Author

Mapchecker is happy! Thanks for doing the technical bit for me, I appreciate that.

not a problem

@MagnusCrowe
Copy link
Contributor

image

@dvir001 dvir001 requested a review from MagnusCrowe January 14, 2024 15:01
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 14, 2024
@Cheackraze Cheackraze merged commit 288b499 into new-frontiers-14:master Jan 18, 2024
10 of 11 checks passed
FrontierATC added a commit that referenced this pull request Jan 18, 2024
@YumiGumi YumiGumi deleted the SLI-Ship-Reworks branch February 1, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants