Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xeno noghostrole #845

Merged
merged 11 commits into from
Jan 8, 2024
Merged

Conversation

TsjipTsjip
Copy link
Contributor

About the PR

  • Remove ghostrole from the MobXeno component
  • Re-add ghostrole to the MobXenoQueenDungeon component

Why / Balance

Make anomalous lab xenos no longer be ghostroles.

Technical details

XenoAISpawner (the spawner used in the bluespace asteroids and the anomalous lab) is a Nyano thing which lists all protos that parent off of MobXeno.

MobXenoQueenDungeon parents off of MobXenoQueen, which parents off of MobXeno. Adding the ghostrole component to MobXenoQueenDungeon should ensure that dungeon megafauna are the only xenos that spawn as a ghostrole. Also added a suffix to indicate this.

The only actual impact this has is on the bluespace asteroids and the anomalous lab, as these protos appear to be used exclusively there.

Changelog

  • tweak: Most xenos are no longer ghostroles by default. (Dungeon megafauna are still ghostroles.)

@MagnusCrowe MagnusCrowe requested a review from dvir001 January 8, 2024 08:36
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jan 8, 2024
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working

@dvir001 dvir001 merged commit f53ea0e into new-frontiers-14:master Jan 8, 2024
9 of 11 checks passed
@TsjipTsjip TsjipTsjip deleted the xeno-noghostrole branch January 30, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# S: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants