Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Praeda rework #833

Merged
merged 12 commits into from
Jan 7, 2024
Merged

Praeda rework #833

merged 12 commits into from
Jan 7, 2024

Conversation

TsjipTsjip
Copy link
Contributor

@TsjipTsjip TsjipTsjip commented Jan 6, 2024

About the PR

  • Remove command encryption key
  • Remove engineering encryption key
  • Replace fully filled telecomms server with ship (non-sec) variant
  • Move fax machine closer to shuttle console
  • Remove custom-filled captain locker
  • Add standard captain locker
  • Move captain suit storage
  • Remove deckard and ammo
  • Remove CE's python and ammo
  • Remove docking airlock insanity (the extra labels each. and. every. single. docking. airlock. had. STC's rejoice)

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Screenshot from 2024-01-06 14-46-32

Breaking changes

Changelog
🆑

  • tweak: Praeda was reworked.

@TsjipTsjip TsjipTsjip marked this pull request as draft January 6, 2024 13:56
@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Jan 6, 2024
@TsjipTsjip
Copy link
Contributor Author

Draft until #821 is merged. Diff is messy until this is done, as this branch contains commits from #821 .

@MagnusCrowe
Copy link
Contributor

Draft until #821 is merged. Diff is messy until this is done, as this branch contains commits from #821 .

Merged #821

@dvir001 dvir001 marked this pull request as ready for review January 7, 2024 17:22
@dvir001
Copy link
Contributor

dvir001 commented Jan 7, 2024

Can you set the AME to working on 4? and add a fuel tank to it.
It best if its running with the ship as you buy it

Also its possible to wrench the O2, and N2 to save hussle

@TsjipTsjip
Copy link
Contributor Author

Requested changes applied. Mapchecker will fail on a different shuttle, fixing that one in a separate PR.

@Cheackraze Cheackraze merged commit 51a926d into new-frontiers-14:master Jan 7, 2024
9 of 11 checks passed
FrontierATC added a commit that referenced this pull request Jan 7, 2024
@TsjipTsjip TsjipTsjip deleted the praeda-rework branch January 30, 2024 07:44
@drhat
Copy link
Contributor

drhat commented Aug 2, 2024

Can I get some explanations as to what is meant by the airlock stuff? I labeled them so they were easy to identify when docking

@ThatOneGoblin25
Copy link
Contributor

Can I get some explanations as to what is meant by the airlock stuff? I labeled them so they were easy to identify when docking

Naming entities means they have English characters for non-english players. I also noticed in your ship there's a lot of named items and session modified items. Comb through your yml and look into the items with the metadata component, you shouldn't really have any item with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants