Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL changes on the matter of life and death #782

Merged

Conversation

Mnemotechnician
Copy link
Contributor

About the PR

  • Crematories will no longer accept connected players or alive mobs, similarly to biomass reclaimers.
  • Fixed a bug where if and only if you clicked the "return to body" button while being a ghost, ghostrespawn would require waiting hours before respawning, depending on how long the shift was going on for and how slow the server was running.
  • Added support for components that are carried over upon cloning. Currently this is used to carry over the "small" and "tall" traits, but later it can be used to add support for lasting genetic changes.

Why / Balance

The first one is because MY BODY WAS CREMATED ALIVE THAT ONE SHIFT GOD DAMN IT!!! And not only mine, those raiders cremate half the station!!!

The rest are because why not.

Technical details

C# changes
Added an ITransferredByCloning interface and applied it to SizeAttribute and PseudoItem

Media

Change # 1: https://cdn.discordapp.com/attachments/1127687656084611214/1190060682696208464/weeee-2023-12-29_01.33.10.mp4?ex=65a06d61&is=658df861&hm=a066802dad500abb13fa63f1f9509b550dcb64f6bf71a7a577241eca5f21aa83&

Change # 3: https://cdn.discordapp.com/attachments/1127687656084611214/1190091607500935178/aaaaaaaa.mp4?ex=65a08a2e&is=658e152e&hm=e19bcfa71d6129c78b47be358875140e43bb36c8ee62840081de50a0ab333df7&

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None

Changelog
🆑

  • tweak: Crematoriums can no longer be used to cremate alive mobs and players with an active soul
  • tweak: Cloning now preserves your size. Small creatures will no longer become massive after being cloned!

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

No more my legs will grow after cloning and also many nice fixes!

@Cheackraze Cheackraze merged commit e6c4977 into new-frontiers-14:master Dec 29, 2023
9 of 10 checks passed
FrontierATC added a commit that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants