Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice Board #777

Merged
merged 3 commits into from
Dec 29, 2023
Merged

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Dec 27, 2023

About the PR

Notice Board:

  • Wall-mounted.
  • Stores documents.

Why / Balance

Mostly RP. Post requests, steal posted requests and post ascii art instead..

Technical details

.yml, .rsi

Media

image
image

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Changelog
🆑 erhardsteinhauer

  • add: Added notice boards. Accessible through construction menu.

Copy link
Contributor

github-actions bot commented Dec 27, 2023

RSI Diff Bot; head commit 83418b9 merging into a6746bc
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Wallmounts/notice_board.rsi

State Old New Status
base Added
icon Added
notices-1 Added
notices-2 Added
notices-3 Added
notices-4 Added
notices-5 Added
notices-6 Added
notices-7 Added
notices-8 Added

Edit: diff updated after 83418b9

@TsjipTsjip
Copy link
Contributor

TsjipTsjip commented Dec 27, 2023

Pretty sure this is something upstream already has a different version of.

@ErhardSteinhauer
Copy link
Contributor Author

Haven't seen any, but quite possible that they have those.

@dvir001
Copy link
Contributor

dvir001 commented Dec 27, 2023

space-wizards/space-station-14#21410

Is our more cool?
How do we compare?

@ErhardSteinhauer
Copy link
Contributor Author

space-wizards/space-station-14#21410

Is our more cool? How do we compare?

Pffff. Ofc our version is superior: I personally stole sprites from tgstation and done did yml.
But jokes aside both versions are fairly similar. The only real difference is that this version has 8 (9 if you count empty board) sprites for various states of fill whereas upstream has 5 (again, 6 if you count empty one). Also upstream doesn't include recipe for construction menu.

@dvir001
Copy link
Contributor

dvir001 commented Dec 28, 2023

space-wizards/space-station-14#21410
Is our more cool? How do we compare?

Pffff. Ofc our version is superior: I personally stole sprites from tgstation and done did yml. But jokes aside both versions are fairly similar. The only real difference is that this version has 8 (9 if you count empty board) sprites for various states of fill whereas upstream has 5 (again, 6 if you count empty one). Also upstream doesn't include recipe for construction menu.

I just need you to update our to have have a diffrent ID (Add NF to it) and also add Suffix "Frontier" and we can just add it

@ErhardSteinhauer
Copy link
Contributor Author

I just need you to update our to have have a diffrent ID (Add NF to it) and also add Suffix "Frontier" and we can just add it

Done.

@dvir001
Copy link
Contributor

dvir001 commented Dec 28, 2023

Tried it in game and getting it to open is a bit hard from angles unless you run into it in straight line, not sure if other one have the same issue from upstream but its very hard to open X_X

Other then that its good

@ErhardSteinhauer
Copy link
Contributor Author

ErhardSteinhauer commented Dec 28, 2023

Tried it in game and getting it to open is a bit hard from angles unless you run into it in straight line, not sure if other one have the same issue from upstream but its very hard to open X_X

Other then that its good

Fiddled with this thing for a bit, should now be easier to interact from a distance. Also made sprites for rotated states.

Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its working great now.

@dvir001 dvir001 merged commit 093f80a into new-frontiers-14:master Dec 29, 2023
11 of 12 checks passed
FrontierATC added a commit that referenced this pull request Dec 29, 2023
@dvir001
Copy link
Contributor

dvir001 commented Dec 29, 2023

If you want to map it on frontier you can go for it now.

@ErhardSteinhauer ErhardSteinhauer deleted the Notice-Board branch January 31, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants