Add another bell clothing item #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Resources/Prototypes/_NF/Entities/Clothing/Neck/misc.yml
|
RSI Diff Bot; head commit b2667dc merging into c0cb588 Resources/Textures/_NF/Clothing/Neck/bellcollar.rsi
|
Mine, made in gimp using some other clothing piece as a template for the rsi And oooooops I gotta fix it making the sound while in a pocket- |
FoxxoTrystan
approved these changes
Dec 25, 2023
Cheackraze
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
So recently I discovered jester shoes and I loved the sound they make. But there was one problem: they don't allow you to wear magboots or some other kind of shoes at the same time. So I had the idea to add a new item that would make the bell sound and make it use the neck slot (since it's only used for vanity items), and someone suggested a bell collar. And now here we are!
The item emits the same sound as jester shoes when it moves, or when its wearer moves. It doesn't emit any sound when placed and moved a container, or when its wearer is placed and moved inside a container.
Why / Balance
Monke hears jingling sound -> monke feels happy. Definitely not useful if you plan on sneaking on someone.
Technical details
Added an EmitsSoundOnMove component and the accompanying system.
Media
https://cdn.discordapp.com/attachments/1123826879892299783/1188964506353807591/weeee-2023-12-26_00.58.46.mp4?ex=659c707c&is=6589fb7c&hm=eed6998eff2a563821c05bba039d7f7a2591b66f33209148f8e922084f231777&
Breaking changes
None
Changelog
🆑