Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shipyard tests #485

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Conversation

DebugOk
Copy link
Contributor

@DebugOk DebugOk commented Oct 26, 2023

About the PR

Currently only does 3 things

  1. Attempt to load the maps
  2. Check if the buy price is greater then the sell price
  3. Check if the buy price is at least 5% greater then the sell price

@DebugOk
Copy link
Contributor Author

DebugOk commented Oct 26, 2023

Integration tests apparently aren't ran, making these tests pretty useless

@DebugOk DebugOk closed this Oct 26, 2023
@DebugOk DebugOk reopened this Oct 27, 2023
@DebugOk
Copy link
Contributor Author

DebugOk commented Oct 27, 2023

While automatic tests may be disabled, there may still be a benefit from running this manually. I'm still trying to fix all test failures so the pr ones can be enabled again

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Nov 13, 2023
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Jan 7, 2024
@dvir001 dvir001 requested a review from Cheackraze January 7, 2024 19:12
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jan 7, 2024
@Cheackraze Cheackraze merged commit 0277223 into new-frontiers-14:master Jan 9, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Map-Shuttle Map - Shuttle S: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants