Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gas Miners from POIs and Restore O2 and N2 values #2781

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Cheackraze
Copy link
Member

About the PR

What it says on the tin

Why / Balance

moving away from magically sourced materials towards in-world generated materials aligns with our overall design goals. Allows us to once again pay for all gasses.

How to test

spawn an o2 or n2 gas canister, appraise it using your favorite appraisal tool. Also, notice the 3 major POIs are now without their magic gas miners.

Media

Requirements

Breaking changes

Likely to break shipyard tests/arbitrage due to inherent value of o2/n2, however the values are relatively low and in line with recent values so any price adjustmants would likely be minor.

Changelog

🆑

  • remove: Removed station gas miners
  • tweak: Adjusted gas prices for basic gasses

@@ -76,7 +76,7 @@
gasVisbilityFactor: 3.5
color: 56941E
reagent: Ammonia
pricePerMole: 0.3 # Frontier 0.15<0.3
pricePerMole: 0.5 # Frontier 0.15<0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should keep this 0.15 to avoid people doing ammonia farms again by keeping 50 dead monkey in a room and pumping out.

@github-actions github-actions bot added Map-POI Map - POI Map-Outpost Map - Outpost labels Jan 26, 2025
@dvir001 dvir001 self-requested a review January 26, 2025 22:23
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jan 26, 2025
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Comment the N2/O2 price changes.
  2. A remotely controlled, access-locked gaslock might be useful for filling these outposts back up in case of calamity.

I might argue 2 is a prereq for this - might not be too bad to do given they're tied to atmos consoles (still need to migrate to the monitoring one fwiw)

Edit: could also argue in favour of larger N2/O2 deposits.

Resources/Prototypes/Atmospherics/gases.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Atmospherics/gases.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the size/S label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Outpost Map - Outpost Map-POI Map - POI No C# S: Needs Review This PR is awaiting reviews size/S YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants