Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condiments and condiment recipies #2769

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Havaren
Copy link
Contributor

@Havaren Havaren commented Jan 23, 2025

About the PR

Added more condiments and added recipies for condiments that did not have them

Why / Balance

more flavors and options to specialize for our cooks.
more ways to get things they might need.
future condiments for new recipies.

How to test

load local host
use guidebook to find new recipies.
make them
enjoy the new flavors.

Media

https://i.imgur.com/2rrBJlc.png
https://i.imgur.com/s1UdGP9.png
https://i.imgur.com/lnzbtXr.png
https://i.imgur.com/yssEUdm.png
https://i.imgur.com/aGvfNr1.png
https://i.imgur.com/LeN108e.png
https://i.imgur.com/EV1nBRL.png
https://i.imgur.com/qX96EE1.png
https://i.imgur.com/zgtuevt.png

Requirements

Breaking changes

Changelog

🆑

  • add: Added recipies to condiments lacking them, and some new ones to expand on available flavors

@github-actions github-actions bot added S: Untriaged S: Merge Conflict This PR has conflicts that prevent merging labels Jan 23, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added No C# YML FTL and removed S: Merge Conflict This PR has conflicts that prevent merging labels Jan 23, 2025
@Havaren Havaren changed the title Mint Add condiments and condiment recipies Jan 23, 2025
@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Jan 23, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Jan 23, 2025
@whatston3
Copy link
Contributor

Descriptions could use work, and check capitalization vs. upstream definitions.
RobustToolbox should not be changed - check out 5e97db435c05b4c188184ef90e5d77b0500403d0.
Buffalo sauce isn't butter and hot sauce?
I'd been mulling over the idea of putting black pepper and a generic "spice" reagent in a plant - one you grind, one you juice - would prefer it to "red pepper and ash in a pot", still janky but gives a niche use for particular plants without leaning on chili so much, gives a lot fewer scuffed recipes. Still, this seems to have some ss13 moon logic charm, so cheers.
If relish came out of a recipe with pickles, that seems more reasonable than using saline.

@dvir001
Copy link
Contributor

dvir001 commented Jan 23, 2025

New lines are still broken

image

Please fix.

@Havaren
Copy link
Contributor Author

Havaren commented Jan 23, 2025

Descriptions could use work, and check capitalization vs. upstream definitions. RobustToolbox should not be changed - check out 5e97db435c05b4c188184ef90e5d77b0500403d0. Buffalo sauce isn't butter and hot sauce? I'd been mulling over the idea of putting black pepper and a generic "spice" reagent in a plant - one you grind, one you juice - would prefer it to "red pepper and ash in a pot", still janky but gives a niche use for particular plants without leaning on chili so much, gives a lot fewer scuffed recipes. Still, this seems to have some ss13 moon logic charm, so cheers. If relish came out of a recipe with pickles, that seems more reasonable than using saline.

pickles make saline when juiced. if/when thats changed, i would love to see that updated.

I am not sure how RobustToolbox got in there. i did nothing to it.

@Havaren
Copy link
Contributor Author

Havaren commented Jan 23, 2025

New lines are still broken

image

Please fix.

you got it. double checked other files as well. will work on keep things cleaner.

@Havaren Havaren requested a review from dvir001 January 29, 2025 09:44
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jan 29, 2025
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In summary, needs work, some good stuff in here, some possibility to extend out into new systems, but some bloat and some oddities as-is.

General thoughts:

If cargo sauce was an actual proprietary thing and not just craftable with ingredients on hand, I could see that. Throw barrels of it on wrecks, map one on McCargo, good stuff.

Relish is fine and good, but crafting it should be a microwave recipe - using saline is weird. Look into what Nyanotrasen did for pesto (which should return here, a whole bunch of easily addable foods with that), bechamel, and tomato sauce. You can do the same thing and get little bowls of relish that (I think) turn back into the normal bowl when emptied, so the bowl can be reused. Ensure the solution is transferrable outwards, and we can add a "dippable" system that could be fun, and give a plausible use to queso.

Thousand island, tartar sauce, honey barbecue sauce, peppermint and buffalo sauce as flavours and distinct reagents are effectively bloat - they should taste like the sum of their parts, e.g. "pickles and mayo". If you made your own house versions to get the flavours you want (which you can and should do), there's little win here. I'd recommend removing them entirely. If you wanted to change the existing barbecue sauce's flavor to "sweet and smoky" or something, fine.

Sour cream is fine but the recipe strikes me as odd.

The use of "an incredibly hot hot sauce" as a bootleg space pen are kind of funny, and the fact that your lizard sauce doesn't do anything seems like a waste. Ditto for "nuke sauce".

The recipe for astrotame seems really simple - you could take a scuffed approach to the actual synthesis of aspartame and react phenol with ethanol and some sort of acid at temp.

I still think a spice plant is better than a chili and ash recipe.

Comment on lines +70 to +73
Hotsauce:
amount: 1
CapsaicinOil:
amount: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not hot sauce and butter?
Also, this'll probably react in existing foods if people add hot sauce to them, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was initially just hotter sause.
Would butter also not react if it something was deep fried in ghee?
Maybe add a stir to it, in addition to butter?

flavor-complex-relish = like dill and vinegar
flavor-complex-sourcream = like sour milk
flavor-complex-tartar = dill and fish
flavor-complex-thousandisland = like creamy, sweet, tangy, and salty
flavor-complex-fine-noodles = like fine noodles
flavor-complex-rich-broth = rich broth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
flavor-complex-rich-broth = rich broth
flavor-complex-rich-broth = like rich broth

While we're here :)

Comment on lines 106 to 107
products:
NukeSauce: 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why three?

Comment on lines 1 to 3
reagent-physical-desc-lizardsauce = liquid lava
reagent-physical-desc-coldfire = frozen fire
reagent-physical-desc-sourcream = sour milk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reagent-physical-desc-lizardsauce = liquid lava
reagent-physical-desc-coldfire = frozen fire
reagent-physical-desc-sourcream = sour milk
reagent-physical-desc-lizardsauce = unquenchable
reagent-physical-desc-coldfire = frigid

These don't make grammatical sense as "this {desc} liquid". Here's a few suggestions. I'd recommend renaming the fluent tags to the actual names of the descriptions.

The sour cream one wasn't used.

Comment on lines 11 to 21
- type: reaction
id: CookingBechamel
reactants:
Butter:
amount: 1
Flour:
amount: 5
Milk:
amount: 10
products:
Bechamel: 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really want a singular unit of butter here? Some roux. Why does this one not have a temperature when you make it by stirring it on a stovetop?

Blackpepper: 2

- type: reaction
minTemp: 320
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does cargo sauce need a minTemp?
Stirring, sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesnt. it was to prevent it from just combining in a burger where you wouldnt want it. stiring would be fine.

Comment on lines +136 to +138
SulfuricAcid:
amount: 1
catalyst: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why not use cream? It's fatty.
  2. Why use sulfuric acid? If universal enzyme is your yeast/bacteria/rennet standin, why not use that and stir? Want mozzarella, fine, want sour cream, stir.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1: agree
2: mozz and other cheeses just react. so it would be a super pain to make most times, without just making cheese constantly.

@whatston3 whatston3 added S: Awaiting Changes This PR has changes that need to be made before merging and removed S: Untriaged S: Needs Review This PR is awaiting reviews labels Jan 30, 2025
@Havaren
Copy link
Contributor Author

Havaren commented Feb 1, 2025

In summary, needs work, some good stuff in here, some possibility to extend out into new systems, but some bloat and some oddities as-is.

Its going to eventally tie in with the food that sketch is doing. I would argue that some oddities make things fun(ny).

General thoughts:

If cargo sauce was an actual proprietary thing and not just craftable with ingredients on hand, I could see that. Throw barrels of it on wrecks, map one on McCargo, good stuff.

like the thought, dont like adding more RNG to an already RNG heavy system.

Relish is fine and good, but crafting it should be a microwave recipe - using saline is weird. Look into what Nyanotrasen did for pesto (which should return here, a whole bunch of easily addable foods with that), bechamel, and tomato sauce. You can do the same thing and get little bowls of relish that (I think) turn back into the normal bowl when emptied, so the bowl can be reused. Ensure the solution is transferrable outwards, and we can add a "dippable" system that could be fun, and give a plausible use to queso.

Yea. pickles make saline when ground or juiced. If im doing another pass, may as well fix that now.
Dippable system would be amazing, but is outside the scope of this PR.
Pesto and proper Tomato sause are on the todo.

Thousand island, tartar sauce, honey barbecue sauce, peppermint and buffalo sauce as flavours and distinct reagents are effectively bloat - they should taste like the sum of their parts, e.g. "pickles and mayo". If you made your own house versions to get the flavours you want (which you can and should do), there's little win here. I'd recommend removing them entirely. If you wanted to change the existing barbecue sauce's flavor to "sweet and smoky" or something, fine.

thousand island was requested for salads and burger.
Tartar and hony BBQ can be nixed
Pepermint was for more festive candies (candy cane and the like) and alternate flavors for mints and stuff

Sour cream is fine but the recipe strikes me as odd.

we all missed cream. thanks.

The use of "an incredibly hot hot sauce" as a bootleg space pen are kind of funny, and the fact that your lizard sauce doesn't do anything seems like a waste. Ditto for "nuke sauce".

Thats the idea, actually.

The recipe for astrotame seems really simple - you could take a scuffed approach to the actual synthesis of aspartame and react phenol with ethanol and some sort of acid at temp.

I went off of splenda, that modifies sugar with chlorine.

I still think a spice plant is better than a chili and ash recipe.

probably.

@github-actions github-actions bot added the size/M label Feb 1, 2025
@Havaren Havaren requested a review from whatston3 February 6, 2025 09:27
@github-actions github-actions bot added S: Needs Review This PR is awaiting reviews and removed S: Awaiting Changes This PR has changes that need to be made before merging labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants