Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple PR - Cheese Sandwich #2650

Conversation

dustylens
Copy link
Contributor

About the PR

This PR adds a new recipe and image for a simple cheese sandwich.

Why / Balance

This is a simple PR to help someone who was looking at the different elements to put together a new food item. Plus, you know. A nice cheese sandwich.

How to test

Assemble as per the ingredients. Eat it to check the flavor profiles.

Media

ss+(2025-01-02+at+10 45 18)

Requirements

Breaking changes

Changelog

🆑

  • add: Adds a simple cheese sandwich.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

RSI Diff Bot; head commit 982707a merging into 78a4933
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Consumable/Food/Baked/bread.rsi

State Old New Status
cheesesandwich Added

Edit: diff updated after 982707a

FoodBreadPlainSlice: 2
FoodCheeseSlice: 1
reagents:
Mayo: 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mayo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some issues with trying to add a reagent as a normal ingredient.

Plus, you know, dress your sandwich.

Copy link
Contributor

@arimah arimah Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing mayo from the ingredients and instead leaving 5u of "empty space" in the food solution for people to add their own dressing :> Maybe someone wants ketchup, or hot sauce, or mustard!

Copy link
Contributor Author

@dustylens dustylens Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is currently 2u of empty space for the addition of condiments.

The mayo reagent in the recipe, other than striking me as being fine, was to help illustrate how you add a reagent ingredient in a recipe for the person who was asking about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mayo in cheese sandwich is a sin

@dustylens
Copy link
Contributor Author

Alas to my very core I am undone.

This was just a simple PR to help someone out. I suppose there's another lesson in it as well! I'm going to close this one as it has generally done its job.

@dustylens dustylens closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants