-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kegs (DeltaV 2378#) #2618
Merged
Merged
Kegs (DeltaV 2378#) #2618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit * fixes
RSI Diff Bot; head commit 4c8f922 merging into 0686ef9 Resources/Textures/_NF/Objects/Consumable/Drinks/keg_steel.rsi
Resources/Textures/_NF/Objects/Consumable/Drinks/keg_wood.rsi
|
GreaseMonk
approved these changes
Dec 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like kegs are trending right now
Kegs life |
FrontierATC
added a commit
that referenced
this pull request
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
DeltaV-Station/Delta-v#2378
Added wooden barrels and kegs. Wine, Beer, and Root Beer kegs.
Why / Balance
Drinks
How to test
N/A
Media
Requirements
Technical details
Both are fully constructible and deconstructible (though with no SpillAllSolutions completion in constructions, I just used the SolutionEmpty condition to prevent deconstruction of a keg with anything in it). Base wooden barrel sprite adapted from tgstation/tgstation#38977 but redone to fit the style better, plus I sprited the keg wholecloth.
Regular wooden barrel acts like a crate, wooden keg acts like a tank. Keg is set to
5001000 volume; I felt like it needed to be larger than jugs, but not as large as tanks (which are 1500). Wooden kegs and wooden barrels can be constructed with 5 wood (a la crates), but that can be increased if necessary. They are also vaultable :)Refilling kegs is a bit annoying, but doable, with the best approach being dragging jugs onto them similar to the chemmaster. You can also inject into them with syringes. Clicking on them with a bottle or anything will just fill that container, similar to a water cooler. You can also drink directly from them.
Changelog
🆑