Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up Charon + add some features #2597

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

chrome-cirrus
Copy link
Contributor

About the PR

Fixes up a few flaws noted by other players since introduction of the ship. Also adds a few features that others had expressed an interest in, or that I noticed missing myself.

Full list:
-Hopefully remove all of the stray plating under walls
-Scoot some stuff around in the engineering capsule, add a camera router
-Remove mass scanner computer on bridge, add a mass scanner computer in the salvage area
-Add camera monitor to the bridge
-Add cameras in each docking horn and outside the cargo bay blast doors
-Add withdrawal only ATM to cargo bay near the blast door
-Remove salvage EVA locker near the cargo bay blast door, replace it with a maints locker
-Add shutters to external windows with buttons to actuate them
-Move defib cabinet from bridge to transit corridor
-Add buttons to each airlock to toggle door bolts
-Replace arcade game in the galley with a wooden television
-Replace TelecomServerFilledCommon with TelecomServerFilledShuttle to be in line with other ships

Why / Balance

Make things nicer!

How to test

Load up the ship in game and have a look around.

Media

Requirements

Breaking changes

Changelog

🆑

  • add: Charon gets shutters and some cameras.
  • tweak: Charon had a bunch of small fixes and additions made.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Dec 21, 2024
@dvir001
Copy link
Contributor

dvir001 commented Jan 3, 2025

Removed all the dungeon spawners, they are fucking with loot and ship price.

@dvir001 dvir001 self-requested a review January 3, 2025 17:02
@github-actions github-actions bot added the S: Needs Review This PR is awaiting reviews label Jan 3, 2025
@dvir001 dvir001 merged commit 70bc1a5 into new-frontiers-14:master Jan 3, 2025
14 checks passed
FrontierATC added a commit that referenced this pull request Jan 3, 2025
@chrome-cirrus
Copy link
Contributor Author

Aww... I really like the random mug ones in particular. If I made a non-dungeon version of that spawner (and made sure everything that could appear in it was equal-value), could it be ship mapping eligible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# S: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants