Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Empess cryosleep #2476

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Conversation

DmitriTheDemon
Copy link
Contributor

About the PR

Added cryosleep chamber to empress in place of morgue slab

Why / Balance

As a flagship the empress when pulled typically remains in the game for the remainder of the round as a pseudo-headquarters. It also frequently collects SSD players from prisoners quitting when incarcerated and officers who are unable to return to NFSDO independently. This would allow for them to be placed into cryosleep without having a wall of Zzz bodies.

Additionally, because the ship typically remains the entire round not being able to uncryo for returning players is not as significant of a concern.

How to test

Spawn empress, validate cryopod exists, cryo, uncryo

Media

Empress Cryosleep Empress Uncryo

Requirements

Breaking changes

N/A

Changelog

🆑

  • tweak: Added cryosleep pod to Empress

Added cryosleep chamber to empress in place of morgue slab
@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Nov 28, 2024
@dvir001
Copy link
Contributor

dvir001 commented Nov 28, 2024

Can't map them on ships till we fix the code,
Right now if you cryo then someone sell the ship you get nuked and cannot respawn out from cryo.

While you are right about the all round thing there are exceptions.

Leave the PR open till someone fix the cryo to move you to frontier.

@dustylens
Copy link
Contributor

dustylens commented Nov 28, 2024

Even if you probably WONT sell the ship during the shift this still seems like it could come back to haunt someone in the event that it does happen. I would caution against putting cryo on these ships for now.

Edit: dvir beat me to it.

@Houtblokje
Copy link
Contributor

Can't map them on ships till we fix the code, Right now if you cryo then someone sell the ship you get nuked and cannot respawn out from cryo.

While you are right about the all round thing there are exceptions.

Leave the PR open till someone fix the cryo to move you to frontier.

doesn't your body get nuked after like 20 minutes anyway?

@GreaseMonk
Copy link
Contributor

to be honest if you cryo on a ship and ship gets sold, we kinda need a system that , in case it gets sold, it moves the body to frontier or something- ideally.

@whatston3
Copy link
Contributor

to be honest if you cryo on a ship and ship gets sold, we kinda need a system that , in case it gets sold, it moves the body to frontier or something- ideally.

Gimme a sec.

@whatston3 whatston3 mentioned this pull request Nov 29, 2024
2 tasks
@dvir001 dvir001 added S: Needs Review This PR is awaiting reviews and removed S: DO NOT MERGE labels Dec 6, 2024
@dvir001
Copy link
Contributor

dvir001 commented Dec 6, 2024

This PR is fine now

@dvir001
Copy link
Contributor

dvir001 commented Dec 6, 2024

@DmitriTheDemon
image

You will need to redo this PR as you saved this as a map and not a grid

@dvir001 dvir001 self-requested a review December 6, 2024 21:06
@dvir001
Copy link
Contributor

dvir001 commented Dec 6, 2024

Fixed the map issue for you.

@dvir001 dvir001 merged commit 6cafb02 into new-frontiers-14:master Dec 6, 2024
15 checks passed
FrontierATC added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# S: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants