Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infiltrator Directional Fans #2468

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Conversation

PeccNeck
Copy link
Contributor

About the PR

Purged Tiny Fans for Directional Fans.

Why / Balance

Directional fan good.

How to test

  • Open specifically either the left or right docking airlocks.
  • Be not spaced.

Requirements

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Nov 26, 2024
@PeccNeck
Copy link
Contributor Author

Airlocks on the Infiltrator are weird for Frontier, courtesy of its origins as a non-frontier ship. Those two docking airlocks are the only two with fans, despite three other external airlocks. I'm unsure if I should unlink the bolts and add fans to them as well or not.

As for the shipyard tests failing, doesn't seem like it's my problem...? Four ships are "underpriced" and this PR goes nowhere near any of them.

Copy link
Contributor

@arimah arimah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, minor change, all good. Being a minimally tweaked usptream shuttle, the Infiltrator could probably benefit from some more love in the future, but for now this is fine. Thank you, @PeccNeck!

@arimah arimah merged commit d798a0e into new-frontiers-14:master Nov 30, 2024
14 checks passed
dvir001 pushed a commit to dvir001/frontier-station-14 that referenced this pull request Dec 27, 2024
Co-authored-by: deltanedas <@deltanedas:kde.org>
whatston3 pushed a commit that referenced this pull request Dec 28, 2024
* buff ore box (#2468)

Co-authored-by: deltanedas <@deltanedas:kde.org>

* Update plant_box.yml

---------

Co-authored-by: deltanedas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants