Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HealingSystem: Check bleeding or restoring blood in HasDamage. #2457

Merged
merged 3 commits into from
Jan 12, 2025

Conversation

whatston3
Copy link
Contributor

@whatston3 whatston3 commented Nov 24, 2024

About the PR

Allows healing items to repeatedly heal if they staunch bleeding or restore blood on a target that isn't damaged in a relevant way (e.g. using gauze or a blood pack on a bleeding body with 50% blood volume, but only radiation damage)

Why / Balance

https://discord.com/channels/1123826877245694004/1307968742340427828

Checks were inconsistent - one of two existing ones looked at restoring blood, neither looked at staunching blood. With different maxBleedAmounts, this becomes much more relevant.

How to test

  1. Spawn Urist.
  2. Spawn bang stick, 200 dmg
  3. Bonk Urist.
  4. Check damage.
  5. Apply Gauze.
  6. Bleeding should stop, blunt damage should be untouched.
  7. Apply blood pack.
  8. Blood should be restored, you should be able to apply a blood pack multiple times until all blood is restored.

Media

Requirements

Breaking changes

Changelog

🆑

  • add: Blood restoring/hemostatic items can be used even if the user isn't damaged.

@github-actions github-actions bot added the C# label Nov 24, 2024
@dvir001
Copy link
Contributor

dvir001 commented Nov 24, 2024

This should probably be a PR on wizden.

@whatston3
Copy link
Contributor Author

This should probably be a PR on wizden.

space-wizards/space-station-14#33526

Did it.

@dvir001 dvir001 self-requested a review January 4, 2025 19:58
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 4, 2025
@Cheackraze Cheackraze merged commit d993914 into new-frontiers-14:master Jan 12, 2025
12 checks passed
FrontierATC added a commit that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants