Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mix up atmos on planets #2430

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Nov 18, 2024

About the PR

Added more gas mixes to expo, made it more simple to tell what they are unless you select unknown.
Selecting unknown will give you one few crazy mixes.

Why / Balance

Add more options and make them more easy to select
Make the "fun" ones random selection

How to test

Open on release or debug
Get expo ship
Look at expo selection
Go on one and see the gas on planet.

Media

image

Requirements

Breaking changes

N/A

Changelog
🆑

  • tweak: Changed and added more atmos selections on planets expeditions.

@blackknight954
Copy link
Contributor

blackknight954 commented Nov 19, 2024

Ooooh, nice

Is there a chance of Tritium atmos by chance?

Also having ammonia as a toxic gas seems interesting

Overall a pretty neat change, albeit the changes from #2421 might discourage players from siphoning Co2, N2O, NH3, basically anything that isnt necesary for tritium/Frezon production.

Additionally, is this going to cause emptying gas canisters on expedition tilesets to actually change their atmos? or are they still going to be static

@dvir001
Copy link
Contributor Author

dvir001 commented Nov 19, 2024

Ooooh, nice

Is there a chance of Tritium atmos by chance?

Also having ammonia as a toxic gas seems interesting

Overall a pretty neat change, albeit the changes from #2421 might discourage players from siphoning Co2, N2O, NH3, basically anything that isnt necesary for tritium/Frezon production.

Additionally, is this going to cause emptying gas canisters on expedition tilesets to actually change their atmos? or are they still going to be static

- type: salvageAirMod
  id: Unknown1
  cost: 5
  desc: salvage-air-mod-unknown
  gases:
    - 5 # oxygen
    - 5 # nitrogen
    - 7.321316 # carbon dioxide
    - 5 # plasma
    - 0 # tritium
    - 34.642633 # water vapor
    - 12.321316 # miasma
    - 34.642633 # nitrous oxide
    - 0 # frezon

- type: salvageAirMod
  id: Unknown2
  cost: 5
  desc: salvage-air-mod-unknown
  gases:
    - 0 # oxygen
    - 0 # nitrogen
    - 17.321316 # carbon dioxide
    - 17.321316 # plasma
    - 0.3 # tritium
    - 33.642633 # water vapor
    - 0 # miasma
    - 34.642633 # nitrous oxide
    - 0.1 # frezon

- type: salvageAirMod
  id: Unknown3
  cost: 5
  desc: salvage-air-mod-unknown
  gases:
    - 20 # oxygen
    - 20 # nitrogen
    - 17.321316 # carbon dioxide
    - 2.321316 # plasma
    - 0.3 # tritium
    - 13.642633 # water vapor
    - 15 # miasma
    - 14.642633 # nitrous oxide
    - 0 # frezon

- type: salvageAirMod
  id: Unknown4
  cost: 5
  desc: salvage-air-mod-unknown
  gases:
    - 15 # oxygen
    - 15 # nitrogen
    - 12.321316 # carbon dioxide
    - 2.321316 # plasma
    - 0.1 # tritium
    - 13.642633 # water vapor
    - 20 # miasma
    - 14.642633 # nitrous oxide
    - 0.5 # frezon

- type: salvageAirMod
  id: Unknown5
  cost: 5
  desc: salvage-air-mod-unknown
  gases:
    - 20 # oxygen
    - 20 # nitrogen
    - 17.321316 # carbon dioxide
    - 1.321316 # plasma
    - 2 # tritium
    - 13.642633 # water vapor
    - 15 # miasma
    - 14.642633 # nitrous oxide
    - 0 # frezon

Nothing changed with canisters.

Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ErhardSteinhauer
Copy link
Contributor

Looks good.

Kinda
image

@dvir001
Copy link
Contributor Author

dvir001 commented Nov 20, 2024

Looks good.

Yes.

@dvir001
Copy link
Contributor Author

dvir001 commented Nov 20, 2024

Probably might need to give this another edit but this is a good start point.

@dvir001 dvir001 merged commit 3a7d49b into new-frontiers-14:master Nov 20, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants