Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the NT StudyHall - Medium Civilian Vessel #1495

Closed

Conversation

Emeralddragon2
Copy link

About the PR

Adds the map and prototype files for the NT StudyHall shuttle.

Why / Balance

Provides a ship designed to encourage educational RP and actual education.

How to test

Spawn as a job on the Frontier Station than purchase the NT StudyHall from the ship console.

Media

Screenshot 2024-06-09 190642

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A

Changelog

🆑

  • add: NT StudyHall shuttle added to the Frontier ship console.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Jun 10, 2024
@GreaseMonk
Copy link
Contributor

Looks like a solidly built ship, i do have to say you could have done more with it's hull shape

@dvir001 dvir001 added the Status: Awaiting Changes This PR has changes that need to be made before merging label Jun 11, 2024
@dvir001
Copy link
Contributor

dvir001 commented Jun 11, 2024

From Discord:

Your pipes setup is a bit fucky,
Dont use 2 way air vents, they are not used upstream also for being a bit under monitored for yml changes.
Dont overlap your distro and air like you did next to the dock area.
Dont use sensors when you have air vents and scrubbers next to them since they are sensors themself.

Do not map any kitchen vending machine, do not map engi locker, you dont need it.

Avoid mapping closets above tables if possible

Replace the trash room machine to a simple reclaimer

Do not map any stamp on the floor, they have a DO NOT MAP on them

Do not map any notes with rewritten stuff on it, its impossible to translate them back to Russian

Missing emergency lights.

Please read the ship guide lines again to make sure everything is fine.

@dvir001 dvir001 requested a review from MagnusCrowe June 11, 2024 08:34
@github-actions github-actions bot added Status: Needs Review This PR is awaiting reviews and removed Status: Awaiting Changes This PR has changes that need to be made before merging labels Jun 11, 2024
@dvir001 dvir001 added Status: Awaiting Changes This PR has changes that need to be made before merging and removed Status: Needs Review This PR is awaiting reviews labels Jun 11, 2024
-Aka Ego


[italic]Regulars we’d like to thank: Suzan Logue (Kimchi Salad), Fara Hanover (Only some Alcohol), Caroline Catherina (Gets an Ice Cream), Josef Metzler (Always Pays), Whitaker Johnson (Works too Hard), Dalton Harris (Dalton’s Homemade Pizzas), Dain Dragofi (Sashimi), Ali Cartway (Creator of the LGH), Paris Keppler (Fellow Entrepreneur), Styx (Crazy Bastard), Harry Handsome (Botany Wizard) and anybody else I’m forgetting![/italic]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every single book and note has to be done as its own file since we cannot translate them when mapped on ship.

- type: Transform
pos: 4.15028,4.6993313
parent: 2
- proto: PortableGeneratorPacman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a ship generator, replace it.

- uid: 521
components:
- type: MetaData
name: secure closet (Locker 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont rename lockers, this cannot be translated if you do this.

@dvir001
Copy link
Contributor

dvir001 commented Jun 11, 2024

Ship missing latejoin spawn point
You dont need to map any spawn point other then latejoin

@dvir001
Copy link
Contributor

dvir001 commented Jun 11, 2024

Ship missing guidebook entry

@dvir001
Copy link
Contributor

dvir001 commented Jun 20, 2024

Leaving this PR closed till an update, when ready again you can ping us on the discord to either reopen this PR, reopen it yourself or you can just open a new PR.

Thanks.

@dvir001 dvir001 closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Awaiting Changes This PR has changes that need to be made before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants