Mail table rework #1477
Merged
Mail table rework #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where is the SR only mail that is a pipe bomb? |
Working on something special. Wait and see. |
FIXME: mail_large.rsi has no copyright info
|
RSI Diff Bot; head commit 4bb2cdd merging into b94e1b8 Resources/Textures/_NF/Objects/Consumable/Smokeables/Cigars/cigar-platinum.rsi
Resources/Textures/_NF/Objects/Specific/Mail/mail_large.rsi
|
…-station-14 into 2024-06-03_mail-table
|
Think this is about mature enough to open for review. Statistics for package weights, breakdown per category and expected value per package available here: https://docs.google.com/spreadsheets/d/1M2g_yAVp7ffzLUXhMSwi_Fj1e8sgw1h1NPOH_Tcvqvk/edit?usp=sharing |
GreaseMonk
approved these changes
Jun 13, 2024
…frontier-station-14 into 2024-06-03_mail-table
…-station-14 into 2024-06-03_mail-table
Also adjusts weights for TacticalMaid (missing a zero), Restraints (cut in half)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
This PR adds and uses a Frontier-specific mail table, and creates some randomization in previously fixed mail drops (e.g. muffins, chocolate bars) to create more interesting mail. All of the previous messages have had a formatting pass, so the threats and calls for help should have a little more bite.
Since this is likely to have more suggestions, I've left it open as a draft for the time being.
Why / Balance
The mail table as-is could use some work (#766 has been open for about five months now). It has many entries that aren't very fun, useful, or interesting to see, so mail is often overlooked. This PR attempts to address this.
#1473 is proposing changes to the frequency of mail. The mail table should be appropriate to whatever this ends up being - items in the mail should be interesting enough (on average) for their frequency (currently averaging about 1 piece of mail per user per two hours on the head of that branch).
I attempted to leave the existing mail config as-is. If we don't need to worry about Nyanotrasen changes, I can overwrite or remove them outright.
How to test
Build & run locally.
Media
Breaking changes
None.
Changelog
🆑